Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #8947 - Lint check for licenses in Kotlin/Java source files #15639

Merged
merged 8 commits into from
Oct 17, 2020
Merged

For #8947 - Lint check for licenses in Kotlin/Java source files #15639

merged 8 commits into from
Oct 17, 2020

Conversation

juan-goncalves
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@juan-goncalves juan-goncalves requested review from a team as code owners October 2, 2020 19:03
@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@juan-goncalves juan-goncalves changed the title Lint check for licenses in Kotlin/Java source files (#8947) For #8947 - Lint check for licenses in Kotlin/Java source files Oct 2, 2020
@gabrielluong gabrielluong added the needs:review PRs that need to be reviewed label Oct 12, 2020
@liuche liuche mentioned this pull request Oct 16, 2020
3 tasks
@liuche
Copy link
Contributor

liuche commented Oct 16, 2020

@juan-goncalves can you rebase this to resolve the conflicts? Thanks!

@juan-goncalves
Copy link
Contributor Author

Hey @liuche! Done, conflicts resolved

@ekager
Copy link
Contributor

ekager commented Oct 16, 2020

thanks so much for your PR @juan-goncalves this looks great!

@liuche
Copy link
Contributor

liuche commented Oct 16, 2020

Seems like some kind of toolchain error, so I'll retry:

TEST: classMethod
[task 2020-10-16T21:53:41.113Z] *** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message can't create byte arrau at JPLISAgent.c line: 813

@ekager ekager merged commit 6d69910 into mozilla-mobile:master Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants