Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Homeview UI #158

Merged
merged 9 commits into from
Jan 12, 2019
Merged

Homeview UI #158

merged 9 commits into from
Jan 12, 2019

Conversation

boek
Copy link
Contributor

@boek boek commented Jan 11, 2019

No description provided.

@ghost ghost assigned boek Jan 11, 2019
@ghost ghost added the in progress label Jan 11, 2019
Copy link
Contributor

@colintheshots colintheshots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of MotionLayouts. We'll want to improve the logic later to remove UI manipulations from the Fragment class. Take care for BiDi support.

app/src/main/res/xml/home_scene.xml Show resolved Hide resolved
app/src/main/res/layout/fragment_home.xml Outdated Show resolved Hide resolved
app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt Outdated Show resolved Hide resolved
@@ -77,7 +77,7 @@ private class SessionsAdapter(val context: Context) : RecyclerView.Adapter<Sessi
return ViewHolder(textView)
}

override fun getItemCount(): Int = 0
override fun getItemCount(): Int = 100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahah, I actually didn’t mean to commit that! But it does help demonstrate the motionlayout 😹😹😹

@colintheshots colintheshots merged commit cefa122 into mozilla-mobile:master Jan 12, 2019
@ghost ghost removed the in progress label Jan 12, 2019
@boek boek deleted the i150-homeview_ui branch January 14, 2019 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants