This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #15720 - Remove unused telemetry #15887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuche
reviewed
Oct 15, 2020
| @@ -1625,67 +1610,6 @@ activation: | |||
| no_lint: | |||
| - USER_LIFETIME_EXPIRATION | |||
|
|
|||
| qr_scanner: | |||
There was a problem hiding this comment.
cc @eliserichards for qr scanner telemetry - when chatting with vesta we had the question about whether we ported the original QR telemetry over to the new search experience. If it's not relevant to the new experience then we wanted to remove it.
|
The QR scanner telemetry can be removed. There will be changes made to the functionality in #16189 and I want to have another discussion with Vesta/Marissa about what events will be useful after the UX work is finalized. |
eliserichards
approved these changes
Nov 5, 2020
codrut-topliceanu
force-pushed
the
remove_unsed_telemetry
branch
from
2b055e3
to
ad6fc61
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #15720
Pull Request checklist
To download an APK when reviewing a PR: