Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #15796 - show device language under follow device language #15966

Merged
merged 2 commits into from Oct 16, 2020
Merged

For #15796 - show device language under follow device language #15966

merged 2 commits into from Oct 16, 2020

Conversation

gabrielluong
Copy link
Member

Fixes #15796. Original PR #15838

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@gabrielluong gabrielluong requested review from a team as code owners October 16, 2020 15:36
@gabrielluong gabrielluong mentioned this pull request Oct 16, 2020
Closed
3 tasks
liuche
liuche approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fixed 👍

@gabrielluong gabrielluong merged commit 412b412 into mozilla-mobile:master Oct 16, 2020
@gabrielluong gabrielluong deleted the 15796_show_device_language_under_follow_device_language branch October 16, 2020 16:48
eliserichards
eliserichards reviewed Oct 16, 2020
View reviewed changes
Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not using locale.getDisplayName(locale).capitalize(locale) like line 41?

@gabrielluong gabrielluong mentioned this pull request Oct 16, 2020
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eliserichards eliserichards eliserichards left review comments

@liuche liuche liuche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show selected language in "Follow device language" summary
4 participants
@gabrielluong @liuche @eliserichards @joc-a