For #11397 - Add lint rule for AppCompatResources instead of ContextCompat

[juan-goncalves]

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[firefoxci-taskcluster]

No Taskcluster jobs started for this pull request

The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

[ekager]

I think we can just do testImplementation Deps.junitApi (Just pulled this into #16041 to make sure the other license tests can run)

[juan-goncalves]

Great!
I checked out the Versions object and it had JUnit 5 so I went for the hardcoded version (definitely expecting a review comment), didn't check the Deps object though

I'll update it to testImplementation Deps.junitApi then :)

[ekager]

nit - license (haha maybe the linter would have caught this :P )

[juan-goncalves]

Oh lol, I missed it (I guess I don't see the top of my files often haha)

[juan-goncalves]

Hm, I'm not getting the LicenseDetector warning on test files, maybe there's something I need to configure?

[ekager]

2 nits!

[juan-goncalves]

Done! @ekager

[ekager]

looks good! :)

[ekager]

So looks like there are 6 lint errors where we are using the wrong thing here - would you mind fixing those here too? :)

[juan-goncalves]

Of course, just fixed those 6 calls (reported by the linter) :)
@ekager

[codecov-io]

Codecov Report

Merging #16011 into master will not change coverage.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##             master   #16011   +/-   ##
=========================================
  Coverage     29.86%   29.86%           
+ Complexity     1191     1190    -1     
=========================================
  Files           453      453           
  Lines         18535    18535           
  Branches       2407     2407           
=========================================
  Hits           5535     5535           
  Misses        12606    12606           
  Partials        394      394           

Impacted Files	Coverage Δ	Complexity Δ
.../java/org/mozilla/fenix/browser/BrowserFragment.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...onents/tips/providers/MasterPasswordTipProvider.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...brary/recentlyclosed/RecentlyClosedFragmentView.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...a/org/mozilla/fenix/search/SearchDialogFragment.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...a/fenix/browser/readermode/ReaderModeController.kt	100.00% <100.00%> (ø)	0.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c941bd9...e7c3668. Read the comment docs.

[ekager]

Looks good, let's land it!