This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update Android Components, Kotlin, Gradle plugin #16021
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed ui test passes locally, so I assume it's just an intermittent. Let's retry.. |
Codecov Report
@@ Coverage Diff @@
## master #16021 +/- ##
============================================
- Coverage 29.87% 29.78% -0.09%
- Complexity 1190 1191 +1
============================================
Files 453 453
Lines 18535 18472 -63
Branches 2407 2539 +132
============================================
- Hits 5537 5502 -35
+ Misses 12605 12552 -53
- Partials 393 418 +25
Continue to review full report at Codecov.
|
It's green. It's greeeeen. 💚 |
rocketsroger
approved these changes
Oct 19, 2020
rocketsroger
added
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
and removed
needs:review
PRs that need to be reviewed
labels
Oct 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, here we go again. We landed the updates in AC again and this is the matching Fenix PR with the AC version bump and other required changes.