Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Update Android Components, Kotlin, Gradle plugin #16021

Merged
merged 7 commits into from
Oct 19, 2020

Conversation

pocmo
Copy link
Contributor

@pocmo pocmo commented Oct 19, 2020

Okay, here we go again. We landed the updates in AC again and this is the matching Fenix PR with the AC version bump and other required changes.

@pocmo pocmo requested review from a team as code owners October 19, 2020 12:10
@pocmo pocmo added the needs:review PRs that need to be reviewed label Oct 19, 2020
@pocmo
Copy link
Contributor Author

pocmo commented Oct 19, 2020

Failed ui test passes locally, so I assume it's just an intermittent. Let's retry..

@pocmo pocmo closed this Oct 19, 2020
@pocmo pocmo reopened this Oct 19, 2020
@codecov-io
Copy link

Codecov Report

Merging #16021 into master will decrease coverage by 0.08%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #16021      +/-   ##
============================================
- Coverage     29.87%   29.78%   -0.09%     
- Complexity     1190     1191       +1     
============================================
  Files           453      453              
  Lines         18535    18472      -63     
  Branches       2407     2539     +132     
============================================
- Hits           5537     5502      -35     
+ Misses        12605    12552      -53     
- Partials        393      418      +25     
Impacted Files Coverage Δ Complexity Δ
.../fenix/exceptions/login/LoginExceptionsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/org/mozilla/fenix/share/ShareFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/org/mozilla/fenix/ext/TabCollection.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...a/fenix/search/telemetry/incontent/TrackKeyInfo.kt 28.57% <0.00%> (-28.58%) 3.00% <0.00%> (ø%)
.../org/mozilla/fenix/perf/StartupReportFullyDrawn.kt 66.66% <0.00%> (-11.12%) 6.00% <0.00%> (ø%)
...pp/src/main/java/org/mozilla/fenix/ext/Fragment.kt 20.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
.../org/mozilla/fenix/tabhistory/TabHistoryAdapter.kt 92.85% <0.00%> (-7.15%) 3.00% <0.00%> (ø%)
app/src/main/java/org/mozilla/fenix/ext/View.kt 84.37% <0.00%> (-6.25%) 0.00% <0.00%> (ø%)
...ain/java/org/mozilla/fenix/components/Analytics.kt 63.26% <0.00%> (-5.37%) 1.00% <0.00%> (ø%)
app/src/main/java/org/mozilla/fenix/ext/String.kt 72.50% <0.00%> (-5.00%) 0.00% <0.00%> (ø%)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ff7a1...71795f9. Read the comment docs.

@pocmo
Copy link
Contributor Author

pocmo commented Oct 19, 2020

It's green. It's greeeeen. 💚

@rocketsroger rocketsroger self-assigned this Oct 19, 2020
@rocketsroger rocketsroger added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Oct 19, 2020
@rocketsroger rocketsroger merged commit 2da24cd into mozilla-mobile:master Oct 19, 2020
@pocmo pocmo deleted the ac-upgrade-kotlin branch October 19, 2020 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants