Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #15910 - Adds back automatic toggle, disables slider when enabled #16070

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Oct 20, 2020

We want to undo this and just disable the slider while auto is enabled

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ekager ekager requested review from a team as code owners October 20, 2020 21:24
@gabrielluong gabrielluong added the needs:review PRs that need to be reviewed label Oct 20, 2020
@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #16070 into master will increase coverage by 0.00%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #16070   +/-   ##
=========================================
  Coverage     29.75%   29.76%           
  Complexity     1191     1191           
=========================================
  Files           453      453           
  Lines         18481    18489    +8     
  Branches       2539     2542    +3     
=========================================
+ Hits           5499     5503    +4     
- Misses        12562    12567    +5     
+ Partials        420      419    -1     
Impacted Files Coverage Δ Complexity Δ
...src/main/java/org/mozilla/fenix/components/Core.kt 21.65% <0.00%> (ø) 1.00 <0.00> (ø)
...rg/mozilla/fenix/settings/AccessibilityFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../fenix/settings/TextPercentageSeekBarPreference.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 69.89% <100.00%> (+0.32%) 35.00 <0.00> (ø)
app/src/main/java/org/mozilla/fenix/Config.kt 54.54% <0.00%> (+4.54%) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0712d...8795307. Read the comment docs.

Copy link
Member

@gabrielluong gabrielluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ assuming we fix the line.

@gabrielluong gabrielluong added pr:approved PR that has been approved pr:needs-changes PRs that need some changes/fixes before they can land and removed needs:review PRs that need to be reviewed labels Oct 21, 2020
@ekager ekager added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed pr:needs-changes PRs that need some changes/fixes before they can land labels Oct 21, 2020
@gabrielluong gabrielluong merged commit d5cb9c5 into mozilla-mobile:master Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants