Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #16084 - match elevation of Tab in Collection to header #16100

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Oct 21, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ekager ekager requested review from a team as code owners October 21, 2020 18:24
@ekager ekager added the needs:review PRs that need to be reviewed label Oct 21, 2020
Copy link
Contributor

@Mugurell Mugurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
🚢 it!

@Mugurell Mugurell self-assigned this Oct 21, 2020
app/src/main/res/values/dimens.xml Outdated Show resolved Hide resolved
@gabrielluong gabrielluong added pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Oct 21, 2020
@codecov-io
Copy link

Codecov Report

Merging #16100 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #16100      +/-   ##
============================================
- Coverage     29.71%   29.71%   -0.01%     
  Complexity     1193     1193              
============================================
  Files           453      453              
  Lines         18532    18533       +1     
  Branches       2546     2546              
============================================
  Hits           5507     5507              
- Misses        12604    12605       +1     
  Partials        421      421              
Impacted Files Coverage Δ Complexity Δ
...oncontrol/viewholders/TabInCollectionViewHolder.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5cb9c5...aadb184. Read the comment docs.

@gabrielluong gabrielluong merged commit 6b8f200 into mozilla-mobile:master Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants