Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

CI for #14636 #16332

Merged
merged 2 commits into from
Nov 3, 2020
Merged

CI for #14636 #16332

merged 2 commits into from
Nov 3, 2020

Conversation

gabrielluong
Copy link
Member

@gabrielluong gabrielluong commented Nov 2, 2020 •
edited

Fixes #14636

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@dglttr @gabrielluong
For mozilla-mobile#14636 - Update preference section headers to use c…
3c9f217 
…orrect color, spacing and rulers

Fixes color in dark mode and misc changes

For mozilla-mobile#14636 - Update preference section headers to use correct color,
spacing and rulers
@dglttr @gabrielluong
Use color variable for text color
a239f1e
@gabrielluong gabrielluong requested review from a team as code owners November 2, 2020 22:35
liuche
liuche approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

carrying over r+ from #15377

@gabrielluong gabrielluong merged commit 2bd2a56 into mozilla-mobile:master Nov 3, 2020
@gabrielluong gabrielluong deleted the section-headers branch November 3, 2020 00:57
@gabrielluong gabrielluong mentioned this pull request Nov 3, 2020
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liuche liuche liuche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Spacing, colours and rulers for section headers in Settings and subpages are incorrect
3 participants
@gabrielluong @liuche @dglttr