Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #15960 - Enable Grid View in Nightly only #16462

Merged
merged 1 commit into from Nov 9, 2020

Conversation

gabrielluong
Copy link
Member

Fixes #15960

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@gabrielluong gabrielluong requested review from a team as code owners November 9, 2020 17:29
@gabrielluong gabrielluong added the needs:review PRs that need to be reviewed label Nov 9, 2020
@pocmo pocmo added pr:approved PR that has been approved and removed needs:review PRs that need to be reviewed labels Nov 9, 2020
@gabrielluong gabrielluong reopened this Nov 9, 2020
@codecov-io
Copy link

Codecov Report

Merging #16462 (baa5605) into master (517ff91) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #16462   +/-   ##
=========================================
  Coverage     29.98%   29.98%           
  Complexity     1220     1220           
=========================================
  Files           455      455           
  Lines         18703    18703           
  Branches       2571     2571           
=========================================
  Hits           5609     5609           
  Misses        12659    12659           
  Partials        435      435           
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 70.90% <100.00%> (ø) 35.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 517ff91...baa5605. Read the comment docs.

@gabrielluong gabrielluong merged commit b5c25cc into mozilla-mobile:master Nov 9, 2020
@gabrielluong gabrielluong deleted the 15960 branch November 9, 2020 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Grid View in Nightly only
3 participants