For #15761 - [Grid View] Enable the grid view and remove its feature flag #16546

gabrielluong · 2020-11-12T22:46:22Z

Pull Request checklist

Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

click on Show All Checks,
click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
click on the "Fenix - assemble" task, then click "Run Artifacts".
the APK links should be on the left side of the screen, named for each CPU architecture

…ings feature flag

…ngs feature flag and show the Tab view preference category

gabrielluong · 2020-11-12T23:03:24Z

app/src/main/java/org/mozilla/fenix/tabtray/TabTrayView.kt

@@ -272,7 +272,6 @@ class TabTrayView(

        @Suppress("ComplexCondition")
        if (
-            view.context.settings().showGridViewInTabsSettings &&


It was missing this the last time.

gabrielluong requested review from a team as code owners November 12, 2020 22:46

gabrielluong added 2 commits November 12, 2020 17:55

For mozilla-mobile#15761 - Part 1: Turn ON the showGridViewInTabsSett…

19d5124

…ings feature flag

For mozilla-mobile#15761 - Part 2: Remove the showGridViewInTabsSetti…

439603f

…ngs feature flag and show the Tab view preference category

gabrielluong force-pushed the 15761 branch from 3283e0b to 439603f Compare November 12, 2020 22:57

gabrielluong commented Nov 12, 2020

View reviewed changes

gabrielluong requested a review from ekager November 13, 2020 00:37

ekager approved these changes Nov 13, 2020

View reviewed changes

gabrielluong merged commit 27ee2ba into mozilla-mobile:master Nov 13, 2020

gabrielluong deleted the 15761 branch September 16, 2021 15:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For #15761 - [Grid View] Enable the grid view and remove its feature flag #16546

For #15761 - [Grid View] Enable the grid view and remove its feature flag #16546

gabrielluong commented Nov 12, 2020

gabrielluong Nov 12, 2020

For #15761 - [Grid View] Enable the grid view and remove its feature flag #16546

For #15761 - [Grid View] Enable the grid view and remove its feature flag #16546

Conversation

gabrielluong commented Nov 12, 2020

Pull Request checklist

To download an APK when reviewing a PR:

gabrielluong Nov 12, 2020

Choose a reason for hiding this comment