Adding menu configuration for A/A experiment and A/B experiment #16692

jhugman · 2020-11-20T18:53:34Z

Fixes #11987

This is the fenix app part of #11987 and SDK-41.

Not in this: the assets, or the telemetry, or the staging server config.

Pull Request checklist

Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

click on Show All Checks,
click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
click on the "Fenix - assemble" task, then click "Run Artifacts".
the APK links should be on the left side of the screen, named for each CPU architecture

jhugman · 2020-11-20T19:04:40Z

Given when menu items are populated, we're going to be racing to enroll for first time run.

codecov-io · 2020-11-20T19:04:53Z

Codecov Report

Merging #16692 (0ceb481) into master (5867d28) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #16692      +/-   ##
============================================
- Coverage     30.11%   30.09%   -0.03%     
  Complexity     1211     1211              
============================================
  Files           454      455       +1     
  Lines         18606    18620      +14     
  Branches       2564     2567       +3     
============================================
  Hits           5604     5604              
- Misses        12559    12573      +14     
  Partials        443      443

Impacted Files	Coverage Δ	Complexity Δ
.../java/org/mozilla/fenix/experiments/Experiments.kt	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...p/src/main/java/org/mozilla/fenix/home/HomeMenu.kt	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5867d28...22a0e8e. Read the comment docs.

jhugman · 2020-11-20T19:19:25Z

I'd love an asset from @mozilla-mobile/ux , or directions where to find the correct one! HALP PLEASE!

violasong · 2020-11-30T16:49:46Z

Hi @jhugman, are you talking about "star in tray" icon? I originally added it to a Jira issue, but here it is again:
Bookmarks List.svg.zip

jhugman · 2020-12-01T14:41:46Z

I originally added it to a Jira issue, but here it is again:
Bookmarks List.svg.zip

Thank you so much!

jhugman · 2020-12-01T18:18:37Z

Hi, @violasong, would you mind providing a square asset?

The way I'm using it at the moment (via the android studio asset importer), it's coming out as 24dp x 29.805dp.

jhugman · 2020-12-01T18:54:28Z

Current status.

jhugman · 2020-12-01T19:59:47Z

Pending an additional asset, this is ready for review.

eliserichards

Two small nits. This is very clear and the comments make this very accessible. I'm happy to approve this once it is ready 🥇

eliserichards · 2020-12-01T20:11:12Z

app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt

+        // We want to validate that the Nimbus experiments library is working, from the android UI
+        // all the way back to the data science backend. We're not testing the user's preference
+        // or response, we're end-to-end testing the experiments platform.
+        // So here, we're running multiple identical branches    with the same treatment, and if the


Nit: whitespace
I really appreciate these comments 👍

also it looks like a let block not a let?

violasong · 2020-12-01T23:33:24Z

Hi, @violasong, would you mind providing a square asset?

The way I'm using it at the moment (via the android studio asset importer), it's coming out as 24dp x 29.805dp.

Ah, sorry about that! It should actually fill a 24 x 24 px space. I re-exported it with extra spacing so that it's square.
bookmarks list x24.svg.zip

Let me know if this looks right when you add it in.

jhugman · 2020-12-02T18:59:37Z

@violasong THANK YOU!
@eliserichards Ready for review. Please land when happy!

eliserichards

Wonderful! Let's land this! 🚀

jhugman requested review from a team as code owners November 20, 2020 18:53

jhugman marked this pull request as draft November 20, 2020 18:53

gabrielluong added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Nov 26, 2020

jhugman force-pushed the jhugman/sdk-41-11987-bookmarks-experiment branch from 91e8d52 to 01fd127 Compare December 1, 2020 18:50

jhugman marked this pull request as ready for review December 1, 2020 19:58

jhugman changed the title ~~WIP: Adding menu configuration for A/A experiment and A/B experiment~~ Adding menu configuration for A/A experiment and A/B experiment Dec 1, 2020

jhugman force-pushed the jhugman/sdk-41-11987-bookmarks-experiment branch from 01fd127 to 0ceb481 Compare December 1, 2020 19:59

jhugman removed the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Dec 1, 2020

eliserichards reviewed Dec 1, 2020

View reviewed changes

Adding menu configuration for A/A experiment and A/B experiment

22a0e8e

jhugman force-pushed the jhugman/sdk-41-11987-bookmarks-experiment branch from 0ceb481 to 22a0e8e Compare December 2, 2020 18:58

eliserichards approved these changes Dec 2, 2020

View reviewed changes

jhugman merged commit 3cd4ff9 into master Dec 3, 2020

bors bot deleted the jhugman/sdk-41-11987-bookmarks-experiment branch December 3, 2020 12:24

data-sync-user mentioned this pull request Feb 19, 2021

Run an empty branch A/A experiment mozilla/experimenter#3590

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding menu configuration for A/A experiment and A/B experiment #16692

Adding menu configuration for A/A experiment and A/B experiment #16692

jhugman commented Nov 20, 2020 •

edited by gabrielluong

jhugman commented Nov 20, 2020

codecov-io commented Nov 20, 2020 •

edited

jhugman commented Nov 20, 2020

violasong commented Nov 30, 2020

jhugman commented Dec 1, 2020

jhugman commented Dec 1, 2020

jhugman commented Dec 1, 2020

jhugman commented Dec 1, 2020

eliserichards left a comment

eliserichards Dec 1, 2020

eliserichards Dec 1, 2020

violasong commented Dec 1, 2020

jhugman commented Dec 2, 2020

eliserichards left a comment

Adding menu configuration for A/A experiment and A/B experiment #16692

Adding menu configuration for A/A experiment and A/B experiment #16692

Conversation

jhugman commented Nov 20, 2020 • edited by gabrielluong

Pull Request checklist

To download an APK when reviewing a PR:

jhugman commented Nov 20, 2020

codecov-io commented Nov 20, 2020 • edited

Codecov Report

jhugman commented Nov 20, 2020

violasong commented Nov 30, 2020

jhugman commented Dec 1, 2020

jhugman commented Dec 1, 2020

jhugman commented Dec 1, 2020

jhugman commented Dec 1, 2020

eliserichards left a comment

Choose a reason for hiding this comment

eliserichards Dec 1, 2020

Choose a reason for hiding this comment

eliserichards Dec 1, 2020

Choose a reason for hiding this comment

violasong commented Dec 1, 2020

jhugman commented Dec 2, 2020

eliserichards left a comment

Choose a reason for hiding this comment

jhugman commented Nov 20, 2020 •

edited by gabrielluong

codecov-io commented Nov 20, 2020 •

edited