Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #16745: Allow preference layout to increase height if needed. #16752

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Nov 26, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

before/ after :

->

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@mcarare mcarare requested review from a team as code owners November 26, 2020 16:13
@codecov-io
Copy link

Codecov Report

Merging #16752 (92bea30) into master (9cd2757) will increase coverage by 0.00%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #16752   +/-   ##
=========================================
  Coverage     30.10%   30.10%           
- Complexity     1203     1206    +3     
=========================================
  Files           454      454           
  Lines         18542    18593   +51     
  Branches       2558     2564    +6     
=========================================
+ Hits           5582     5598   +16     
- Misses        12518    12553   +35     
  Partials        442      442           
Impacted Files Coverage Δ Complexity Δ
...nix/components/toolbar/BrowserToolbarController.kt 83.33% <ø> (-0.39%) 0.00 <0.00> (ø)
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...org/mozilla/fenix/tabtray/TabTrayDialogFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 9.64% <78.57%> (+1.67%) 11.00 <2.00> (+2.00)
...a/org/mozilla/gecko/search/SearchWidgetProvider.kt 24.00% <0.00%> (-11.14%) 1.00% <0.00%> (ø%)
...in/java/org/mozilla/fenix/settings/SupportUtils.kt 79.16% <0.00%> (+2.08%) 14.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d49d710...92bea30. Read the comment docs.

@gabrielluong gabrielluong merged commit b2b558f into mozilla-mobile:master Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants