Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #16603: Disable pull down refresh when activity is in immersive mode #16793

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

rocketsroger
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@rocketsroger rocketsroger added the needs:review PRs that need to be reviewed label Nov 30, 2020
@rocketsroger rocketsroger requested review from a team as code owners November 30, 2020 21:13
@Amejia481 Amejia481 self-requested a review December 1, 2020 20:21
Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add add tests to avoid future regressions? :)

@rocketsroger
Copy link
Contributor Author

Could we add add tests to avoid future regressions? :)

Agreed. My mistake, should have added a test.

@codecov-io
Copy link

codecov-io commented Dec 2, 2020

Codecov Report

Merging #16793 (a153a8f) into master (5867d28) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #16793      +/-   ##
============================================
- Coverage     30.11%   30.09%   -0.03%     
+ Complexity     1211     1206       -5     
============================================
  Files           454      454              
  Lines         18606    18603       -3     
  Branches       2564     2566       +2     
============================================
- Hits           5604     5598       -6     
- Misses        12559    12563       +4     
+ Partials        443      442       -1     
Impacted Files Coverage Δ Complexity Δ
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 9.62% <0.00%> (-0.02%) 11.00 <0.00> (ø)
...lla/fenix/customtabs/ExternalAppBrowserActivity.kt 33.33% <0.00%> (-5.56%) 4.00% <0.00%> (-5.00%)
...components/toolbar/BrowserToolbarMenuController.kt 73.80% <0.00%> (-0.31%) 0.00% <0.00%> (ø%)
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 7.54% <0.00%> (ø) 5.00% <0.00%> (ø%)
...main/java/org/mozilla/fenix/tabtray/TabTrayView.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5867d28...7fe3db9. Read the comment docs.

Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job 🚢 !

@rocketsroger rocketsroger removed the needs:review PRs that need to be reviewed label Dec 2, 2020
@rocketsroger rocketsroger merged commit 26051f7 into mozilla-mobile:master Dec 2, 2020
@rocketsroger rocketsroger deleted the FB_16603 branch December 2, 2020 16:40
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Dec 22, 2020
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants