-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closes #16603: Disable pull down refresh when activity is in immersive mode #16793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add add tests to avoid future regressions? :)
Agreed. My mistake, should have added a test. |
a153a8f
to
8901891
Compare
Codecov Report
@@ Coverage Diff @@
## master #16793 +/- ##
============================================
- Coverage 30.11% 30.09% -0.03%
+ Complexity 1211 1206 -5
============================================
Files 454 454
Lines 18606 18603 -3
Branches 2564 2566 +2
============================================
- Hits 5604 5598 -6
- Misses 12559 12563 +4
+ Partials 443 442 -1
Continue to review full report at Codecov.
|
…is in immersive mode
8901891
to
7fe3db9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job 🚢 !
…is in immersive mode (mozilla-mobile#16793)
…is in immersive mode (mozilla-mobile#16793)
Pull Request checklist
To download an APK when reviewing a PR: