Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Create new android-test-beta build #16814

Merged
merged 10 commits into from Dec 4, 2020

Conversation

JohanLorenzo
Copy link
Contributor

@JohanLorenzo JohanLorenzo commented Dec 2, 2020

Blocks #16786
Depends on #16787
Partly addresses #16120

This PR creates 2 new build-types: beta-firebase and android-test-beta. beta-firebase is a beta-like build that is not optimized and meant to be used on the testing infra called Firebase. Let's build them on push for now. android-test-beta is a special APK that just contains the tests, as far as I understand. We cannot use the regular android-test build because Firebase expects package ID to follow this pattern.

  • APK under test: some.package.id
  • APK containing tests: some.package.id.test

So in the case of beta:

  • APK under test: org.mozilla.firefox_beta
  • APK containing tests: org.mozilla.firefox_beta.test

These 2 APKs were manually tested on Firebase by @isabelrios. We will make the changes regarding tests in #16786.

Let me know if I can provide more details

@codecov-io
Copy link

codecov-io commented Dec 2, 2020

Codecov Report

Merging #16814 (1481192) into master (a2b6ddf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #16814   +/-   ##
=========================================
  Coverage     30.11%   30.11%           
  Complexity     1211     1211           
=========================================
  Files           454      454           
  Lines         18606    18606           
  Branches       2564     2564           
=========================================
  Hits           5604     5604           
  Misses        12559    12559           
  Partials        443      443           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b6ddf...1481192. Read the comment docs.

Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohanLorenzo JohanLorenzo marked this pull request as ready for review December 3, 2020 17:24
@JohanLorenzo JohanLorenzo requested review from a team as code owners December 3, 2020 17:24
Copy link
Contributor

@isabelrios isabelrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! tested the beta apks that were generated and confirmed that the tests were launched on Firebase successfully using beta. By default debug is used, that has not changed.
Thanks Johan!!! Great work!

This reverts commit 87d141d.
@gabrielluong gabrielluong added the pr:approved PR that has been approved label Dec 3, 2020
@JohanLorenzo JohanLorenzo merged commit 9420feb into mozilla-mobile:master Dec 4, 2020
@JohanLorenzo JohanLorenzo deleted the android-test-beta branch December 4, 2020 10:36
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants