Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bug 1676499 - Update perfherder data schema for visual metrics. #16837

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

gmierz
Copy link
Contributor

@gmierz gmierz commented Dec 3, 2020

This patch updates the schema used for validating visual metrics and it also adds a hyphen to the list of possible characters in the tags entries.

See this bug for more information: https://bugzilla.mozilla.org/show_bug.cgi?id=1676499

Try run for these changes: https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=40c831b4b9d0f1e2899d53dbe5bff8da229d6f35

@gmierz gmierz requested review from a team as code owners December 3, 2020 15:46
Copy link
Contributor

@jmaher jmaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as this is in the mozilla-mobile repo, why is Firefox as an enum, that got me to question is there anything we need to update in mozilla-central for geckoview perf testing as well?

@codecov-io
Copy link

Codecov Report

Merging #16837 (21fcfc6) into master (c465521) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #16837   +/-   ##
=========================================
  Coverage     30.26%   30.26%           
  Complexity     1231     1231           
=========================================
  Files           455      455           
  Lines         18654    18654           
  Branches       2577     2577           
=========================================
  Hits           5645     5645           
  Misses        12562    12562           
  Partials        447      447           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c465521...21fcfc6. Read the comment docs.

@gmierz
Copy link
Contributor Author

gmierz commented Dec 3, 2020

as this is in the mozilla-mobile repo, why is Firefox as an enum, that got me to question is there anything we need to update in mozilla-central for geckoview perf testing as well?

This is more of a sync update for the schema from here: https://searchfox.org/mozilla-central/source/testing/mozharness/external_tools/performance-artifact-schema.json

I think we need to build a better method for keeping this schema up to date (along with the visual-metrics script).

I have a PR open here to update Treeherder's schema: mozilla/treeherder#6893
And here's the phab patch to update the mozilla-central schema: https://phabricator.services.mozilla.com/D98359

@gabrielluong gabrielluong added the pr:approved PR that has been approved label Dec 11, 2020
Copy link
Member

@gabrielluong gabrielluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamping this for Fenix.

@gmierz
Copy link
Contributor Author

gmierz commented Dec 16, 2020

@gabrielluong hi can we get this landed?

@gabrielluong gabrielluong merged commit bd16c42 into mozilla-mobile:master Dec 16, 2020
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants