Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #15636 - Focus a11y collection on snackbar view tap #16853

Merged
merged 1 commit into from
Dec 11, 2020
Merged

For #15636 - Focus a11y collection on snackbar view tap #16853

merged 1 commit into from
Dec 11, 2020

Conversation

codrut-topliceanu
Copy link
Contributor

With accessibility enabled, when adding a site to a collection and tapping "View" on the snackbar, we send a request for focus and an AccessibilityEvent.TYPE_VIEW_FOCUSED to the specified collection.

For #15636

Pull Request checklist

  • Tests: This PR does not include any tests as it is only a minor change.
  • Screenshots: This PR includes a GIF.
  • Accessibility: The code in this PR follows accessibility best practices.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

focus a11y collection

For mozilla-mobile#15636 - Focus a11y collection on snackbar view tap
48067fe 
 With accessibility enabled, when adding a site to a collection and tapping "View" on the snackbar, we send a request for focus and an `AccessibilityEvent.TYPE_VIEW_FOCUSED` to the specified collection.
@codrut-topliceanu codrut-topliceanu added the needs:review PRs that need to be reviewed label Dec 7, 2020
mcarare
mcarare approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@mcarare mcarare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also tested and works as intended!

@codrut-topliceanu codrut-topliceanu merged commit 556fea5 into mozilla-mobile:master Dec 11, 2020
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Aug 4, 2021
@codrut-topliceanu @pkirakosyan
For mozilla-mobile#15636 - Focus a11y collection on snackbar view tap (…
9c3bd1d 
…mozilla-mobile#16853)

With accessibility enabled, when adding a site to a collection and tapping "View" on the snackbar, we send a request for focus and an `AccessibilityEvent.TYPE_VIEW_FOCUSED` to the specified collection.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcarare mcarare mcarare approved these changes

Assignees
No one assigned
Labels
needs:review PRs that need to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codrut-topliceanu @mcarare