This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Add withExperiment extension method to Nimbus #16926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
force-pushed
the
jhugman/16925-sdk-99-add-withExperiment-extension-method
branch
from
a309c47
to
c2df473
Compare
pocmo
approved these changes
Dec 10, 2020
| * Short-hand for `mozilla.components.service.nimbus.NimbusApi.getExperimentBranch`. | ||
| */ | ||
| fun NimbusApi.withExperiment(experimentId: String) = | ||
| this.getExperimentBranch(experimentId) |
There was a problem hiding this comment.
Would those extension be something we could ship with the nimbus library?
jhugman
force-pushed
the
jhugman/16925-sdk-99-add-withExperiment-extension-method
branch
from
c2df473
to
b64ec17
Compare
Codecov Report
@@ Coverage Diff @@
## master #16926 +/- ##
============================================
- Coverage 30.89% 30.88% -0.02%
Complexity 1240 1240
============================================
Files 453 454 +1
Lines 18519 18527 +8
Branches 2583 2584 +1
============================================
Hits 5722 5722
- Misses 12338 12346 +8
Partials 459 459
Continue to review full report at Codecov.
|
jhugman
force-pushed
the
jhugman/16925-sdk-99-add-withExperiment-extension-method
branch
from
b64ec17
to
28522d5
Compare
bors
bot
deleted the
jhugman/16925-sdk-99-add-withExperiment-extension-method
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16925.
Adds extension method, then re-implements the existing experiments in the terms of those extension methods.