Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #16390 - Include selected session in session suggestions if opened from home fragment #17127

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

mawen7
Copy link
Contributor

@mawen7 mawen7 commented Dec 18, 2020

For #16390

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@mawen7 mawen7 requested review from a team as code owners December 18, 2020 17:03
@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@codrut-topliceanu codrut-topliceanu added the needs:UX-feedback Needs UX Feedback label Jan 8, 2021
@apbitner
Copy link

Pinging @brampitoyo for review

@mawen7 mawen7 changed the title For #16390 - Include selected session in session suggestions For #16390 - Include selected session in session suggestions if opened from home fragment Jan 25, 2021
@mawen7 mawen7 requested review from codrut-topliceanu and removed request for a team January 25, 2021 10:49
@codrut-topliceanu
Copy link
Contributor

Looks & works great! 👍 awesome job @mawen7 .
I'll start the CI tests.

@codrut-topliceanu codrut-topliceanu mentioned this pull request Jan 25, 2021
3 tasks
@codecov-io
Copy link

Codecov Report

Merging #17127 (ccb700e) into master (c21b41c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #17127      +/-   ##
============================================
- Coverage     32.56%   32.54%   -0.02%     
- Complexity     1311     1312       +1     
============================================
  Files           455      455              
  Lines         19038    19071      +33     
  Branches       2659     2668       +9     
============================================
+ Hits           6199     6207       +8     
- Misses        12348    12374      +26     
+ Partials        491      490       -1     
Impacted Files Coverage Δ Complexity Δ
...a/org/mozilla/fenix/search/SearchDialogFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../mozilla/fenix/search/awesomebar/AwesomeBarView.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/org/mozilla/gecko/search/SearchWidgetProvider.kt 24.00% <0.00%> (-4.89%) 1.00% <0.00%> (ø%)
...java/org/mozilla/fenix/perf/PerformanceInflater.kt 95.00% <0.00%> (+15.00%) 5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21b41c...ccb700e. Read the comment docs.

@codrut-topliceanu
Copy link
Contributor

@brampitoyo Please approve changes when you get the chance.

@eliserichards eliserichards added needs:UX-feedback Needs UX Feedback pr:needs-landing PRs that are ready to land [Will be merged by Mergify] labels Jan 25, 2021
@gabrielluong gabrielluong added needs:UX-review and removed needs:UX-feedback Needs UX Feedback labels Jan 26, 2021
Copy link

@brampitoyo brampitoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, @codrut-topliceanu! r+

pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants