This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #16390 - Include selected session in session suggestions if opened from home fragment #17127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
codrut-topliceanu
suggested changes
Jan 7, 2021
app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarView.kt
Outdated
Show resolved
Hide resolved
Pinging @brampitoyo for review |
brampitoyo
suggested changes
Jan 25, 2021
app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarView.kt
Outdated
Show resolved
Hide resolved
mawen7
commented
Jan 25, 2021
Looks & works great! 👍 awesome job @mawen7 . |
Codecov Report
@@ Coverage Diff @@
## master #17127 +/- ##
============================================
- Coverage 32.56% 32.54% -0.02%
- Complexity 1311 1312 +1
============================================
Files 455 455
Lines 19038 19071 +33
Branches 2659 2668 +9
============================================
+ Hits 6199 6207 +8
- Misses 12348 12374 +26
+ Partials 491 490 -1
Continue to review full report at Codecov.
|
codrut-topliceanu
approved these changes
Jan 25, 2021
@brampitoyo Please approve changes when you get the chance. |
brampitoyo
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, @codrut-topliceanu! r+
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this pull request
Aug 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #16390
Pull Request checklist
To download an APK when reviewing a PR: