Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #9778: Site permission settings item height set to 48dp #17134

Conversation

marcellogalhardo
Copy link
Contributor

@marcellogalhardo marcellogalhardo commented Dec 18, 2020

Increases Site Permission, Quick Settings item height to 48dp for compliance with "Google Accessibility Scanner". This is a small UI changed and no tests are required to change.

Fix #9778.

Before After
Screenshot_1608330811 Screenshot_1608330664

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@eliserichards
Copy link
Contributor

This looks great! I will reach out to get a UX review on this :)

@eliserichards eliserichards added the needs:UX-feedback Needs UX Feedback label Dec 18, 2020
@topotropic topotropic removed the needs:UX-feedback Needs UX Feedback label Jan 4, 2021
@topotropic
Copy link

LGTM, thanks!

@gabrielluong gabrielluong self-assigned this Jan 4, 2021
@gabrielluong gabrielluong added pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify] labels Jan 4, 2021
@codecov-io
Copy link

Codecov Report

Merging #17134 (c871e4f) into master (ca36ffe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #17134   +/-   ##
=========================================
  Coverage     30.81%   30.81%           
  Complexity     1239     1239           
=========================================
  Files           455      455           
  Lines         18668    18668           
  Branches       2615     2615           
=========================================
  Hits           5753     5753           
  Misses        12453    12453           
  Partials        462      462           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6962c96...c871e4f. Read the comment docs.

@gabrielluong gabrielluong merged commit b34cc24 into mozilla-mobile:master Jan 4, 2021
@gabrielluong
Copy link
Member

@marcellogalhardo Thank you for the patch!

@marcellogalhardo marcellogalhardo deleted the 9778/site-permission-touch-area branch January 4, 2021 13:56
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][a11y] Site Permission-Touch target-Site permissions statuses need to have the touch target resized
5 participants