Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #17291 - Display a list of all active Nimbus experiments #17515

Merged
merged 1 commit into from Mar 26, 2021
Merged

For #17291 - Display a list of all active Nimbus experiments #17515

merged 1 commit into from Mar 26, 2021

Conversation

gabrielluong
Copy link
Member

@gabrielluong gabrielluong commented Jan 18, 2021 •
edited

Fixes #17291, Requires mozilla-mobile/android-components#9479

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@gabrielluong gabrielluong added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Jan 18, 2021
Amejia481
Amejia481 reviewed Jan 18, 2021
View reviewed changes
app/src/main/java/org/mozilla/fenix/nimbus/NimbusDetailAdapter.kt Outdated Show resolved Hide resolved
app/src/main/java/org/mozilla/fenix/nimbus/NimbusDetailItemViewHolder.kt Outdated Show resolved Hide resolved
app/src/main/java/org/mozilla/fenix/nimbus/NimbusDetailsFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/org/mozilla/fenix/nimbus/NimbusExperimentAdapter.kt Outdated Show resolved Hide resolved
app/src/main/java/org/mozilla/fenix/nimbus/NimbusExperimentItemViewHolder.kt Outdated Show resolved Hide resolved
app/src/main/res/layout/fragment_nimbus_experiments.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/nimbus_branch_item.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/nimbus_experiment_item.xml Outdated Show resolved Hide resolved
app/src/main/res/values/static_strings.xml Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@gabrielluong gabrielluong added the pr:needs-ac-bump PR that needs a AC bump label Jan 22, 2021
@gabrielluong gabrielluong mentioned this pull request Jan 22, 2021
Merged
4 tasks
@gabrielluong gabrielluong removed pr:needs-ac-bump PR that needs a AC bump pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on labels Mar 26, 2021
@gabrielluong gabrielluong marked this pull request as ready for review March 26, 2021 16:31
@gabrielluong gabrielluong requested review from a team as code owners March 26, 2021 16:31
@gabrielluong gabrielluong changed the title For #17291 - Part 1: Display a list of all active Nimbus experiments For #17291 - Display a list of all active Nimbus experiments Mar 26, 2021
Amejia481
Amejia481 approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@gabrielluong gabrielluong merged commit 5d0af34 into mozilla-mobile:master Mar 26, 2021
@gabrielluong gabrielluong deleted the 17291 branch March 26, 2021 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Amejia481 Amejia481 Amejia481 approved these changes

Assignees

@Amejia481 Amejia481

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nimbus: Add tooling for application testing of different branches
2 participants
@gabrielluong @Amejia481