This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Workflow to build contributor PRs #17843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17843 +/- ##
============================================
- Coverage 32.97% 32.96% -0.02%
+ Complexity 1383 1382 -1
============================================
Files 461 461
Lines 19426 19425 -1
Branches 2712 2712
============================================
- Hits 6406 6403 -3
- Misses 12487 12488 +1
- Partials 533 534 +1
Continue to review full report at Codecov.
|
|
Please rebase, the blocking test was disabled: f0b7b3b |
|
Do we really want that though? We had travis/buddybuild and others in parallel and it was always triple the pain to have two build systems. |
@pocmo Very good point. We discussed with RelEng and agreed this would be a temporary solution until we can build contributor PRs on on Task Cluster using the same CI (or subset) of what we use. I also included checks in this workflow so that it will only run on forks so it should not get in the way of work happening in the main repo. |
st3fan
force-pushed
the
st3fan/workflow
branch
from
5a4a3ea
to
566261f
Compare
st3fan
force-pushed
the
st3fan/workflow
branch
2 times, most recently
from
8e2f17c
to
49d629a
Compare
|
Is this a test that requires a device? Similar ... |
|
This is odd? |
Closed
|
I switched to JDK 1.8 instead of 11 and that seems to have gotten rid of the weird failures (SSL related and those tests for LG and Samsung). What is left are now these: What do you think @pocmo - these are fine on TaskCluster - what could make these run different on GitHub? |
|
@pocmo is it possible that these tests depend on a GeoIP lookup and that the GitHub actions run in a different country than Task Cluster? Just a random guess ... |
|
Fix for failing tests at #18048 - when that lands, rebase this patch and it is ready to land. |
st3fan
force-pushed
the
st3fan/workflow
branch
from
a6e82b0
to
44b76e0
Compare
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this pull request
Aug 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental GitHub Actions Workflow to build contributor pull requests. I took most of this workflow from https://github.com/fork-maintainers/iceraven-browser and modified it slightly.
TODO Enable the checks to make sure this only runs on forks.