Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #18198 - Add a feature flag for Credit Cards and Addresses autofill feature #18200

Merged
merged 1 commit into from Feb 26, 2021

Conversation

gabrielluong
Copy link
Member

Fixes #18198

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2021

This pull request has conflicts when rebasing. Could you fix it @gabrielluong? 🙏

@codecov-io
Copy link

Codecov Report

Merging #18200 (d40902c) into master (607d638) will increase coverage by 0.13%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18200      +/-   ##
============================================
+ Coverage     32.96%   33.09%   +0.13%     
- Complexity     1413     1415       +2     
============================================
  Files           460      460              
  Lines         19440    19458      +18     
  Branches       2987     2987              
============================================
+ Hits           6408     6440      +32     
+ Misses        12377    12363      -14     
  Partials        655      655              
Impacted Files Coverage Δ Complexity Δ
...g/mozilla/fenix/settings/SecretSettingsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt 100.00% <100.00%> (ø) 6.00 <2.00> (+2.00)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 72.54% <100.00%> (+0.45%) 36.00 <0.00> (ø)
...rg/mozilla/fenix/settings/account/AccountUiView.kt 32.50% <0.00%> (-2.50%) 4.00% <0.00%> (ø%)
...components/toolbar/BrowserToolbarMenuController.kt 70.15% <0.00%> (+9.94%) 0.00% <0.00%> (ø%)
...rg/mozilla/fenix/components/toolbar/ToolbarMenu.kt 86.95% <0.00%> (+17.39%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607d638...d40902c. Read the comment docs.

@gabrielluong gabrielluong merged commit 968b7bf into mozilla-mobile:master Feb 26, 2021
@gabrielluong gabrielluong deleted the 18198 branch February 26, 2021 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a feature flag for Credit Cards and Addresses autofill features
3 participants