Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No issue: Enable the tabs tray refactor in nightly #18858

Merged
merged 1 commit into from Apr 7, 2021

Conversation

jonalmeida
Copy link
Contributor

We have our core functionality in now, so we can enable this on nightly for folks to test.

There are some known issues that we should fix before we let this ride the trains though.

Screen Shot 2021-04-07 at 4 41 44 PM

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@jonalmeida jonalmeida added the needs:review PRs that need to be reviewed label Apr 7, 2021
@jonalmeida jonalmeida requested a review from a team as a code owner April 7, 2021 20:43
@jonalmeida
Copy link
Contributor Author

For the performance team: opening the tabs tray does not touch cold or warm boot code, so should not affect startup perf.

Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jonalmeida jonalmeida added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Apr 7, 2021
@gabrielluong gabrielluong added the pr:approved PR that has been approved label Apr 7, 2021
@gabrielluong gabrielluong merged commit 80a3475 into mozilla-mobile:master Apr 7, 2021
@jonalmeida jonalmeida deleted the release-the-kraken branch April 7, 2021 23:02
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants