No issue: test one shard per UI test on FTL #18998
Conversation
AaronMT
force-pushed
the
flank-shard-test
branch
from
3ea19c8
to
0cd3eaf
Compare
AaronMT
force-pushed
the
flank-shard-test
branch
from
0cd3eaf
to
0672869
Compare
AaronMT
force-pushed
the
flank-shard-test
branch
2 times, most recently
from
35b2135
to
000035d
Compare
|
Pretty large log reduction with compact, and promising speed with one shard for test. Re-running a few times.
|
Pass in shard arg to ui-test.sh Try out compact logging for log size reduction
AaronMT
force-pushed
the
flank-shard-test
branch
from
000035d
to
d60a2c8
Compare
| @@ -52,7 +52,7 @@ jobs: | |||
| run-on-git-branches: ["^((?!releases[_/]).+)$"] | |||
| run: | |||
| commands: | |||
| - [automation/taskcluster/androidTest/ui-test.sh, x86, app.apk, android-test.apk, '50'] | |||
| - [automation/taskcluster/androidTest/ui-test.sh, x86, app.apk, android-test.apk, '-1'] | |||
There was a problem hiding this comment.
I think this needs a slight bit of housekeeping. If we're using a config file (the flank file) to contain our variables, why should this one stand out as the single variable we need to pass down? I can't remember what the logic was for leaving it this way, but we should be invoking this variable from the flank file (and not in both places). I think you could simply remove it from here and from line #137 and then I believe it would just be picked up from the flank file automagically.
It would probably also be a good idea to make sure the help is up-to-date: https://github.com/mozilla-mobile/fenix/blob/master/automation/taskcluster/androidTest/ui-test.sh#L24-L33
Aside from that nit, LGTM
Testing the speed of test execution on FTL by using one shard per UI test.