Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #19113 - Change topSite corner radius to 8dp #19262

Conversation

codrut-topliceanu
Copy link
Contributor

@codrut-topliceanu codrut-topliceanu commented Apr 27, 2021

Fixes #19113

Pull Request checklist

  • Tests: This PR includes no tests as it is only a minor change.
  • Screenshots: This PR includes screenshots.
  • Accessibility: The code in this PR follows accessibility best practices.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Before:
image

After:
image

Copy link
Member

@gabrielluong gabrielluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me. Let's wait for @brampitoyo's UX review before landing.

Copy link

@brampitoyo brampitoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+!

@gabrielluong gabrielluong added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:UX-review labels Apr 27, 2021
@gabrielluong gabrielluong reopened this Apr 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #19262 (6e14deb) into master (4ee8f15) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19262      +/-   ##
============================================
+ Coverage     34.62%   34.67%   +0.05%     
- Complexity     1614     1615       +1     
============================================
  Files           540      540              
  Lines         21819    21784      -35     
  Branches       3251     3245       -6     
============================================
- Hits           7554     7553       -1     
+ Misses        13367    13335      -32     
+ Partials        898      896       -2     
Impacted Files Coverage Δ Complexity Δ
...rg/mozilla/fenix/settings/account/AccountUiView.kt 36.58% <0.00%> (+2.43%) 4.00% <0.00%> (ø%)
...a/org/mozilla/gecko/search/SearchWidgetProvider.kt 32.50% <0.00%> (+8.50%) 1.00% <0.00%> (ø%)
...java/org/mozilla/fenix/perf/PerformanceInflater.kt 95.00% <0.00%> (+15.00%) 5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee8f15...6e14deb. Read the comment docs.

@gabrielluong gabrielluong merged commit 8f39592 into mozilla-mobile:master Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change border radius for top sites icon from 4dp to 8dp
4 participants