Closes #18253: Bookmark and History open new tabs in the background

[rocketsroger]

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[rocketsroger]

device-2021-04-27-175943.mp4

[codecov-commenter]

Codecov Report

Merging #19275 (ebb2f9b) into master (d71df4d) will decrease coverage by 0.02%.
The diff coverage is 28.20%.

❗ Current head ebb2f9b differs from pull request most recent head 69c5c9e. Consider uploading reports for the commit 69c5c9e to get more accurate results

@@             Coverage Diff              @@
##             master   #19275      +/-   ##
============================================
- Coverage     34.87%   34.85%   -0.03%     
- Complexity     1618     1619       +1     
============================================
  Files           540      540              
  Lines         21816    21846      +30     
  Branches       3249     3259      +10     
============================================
+ Hits           7609     7615       +6     
- Misses        13307    13330      +23     
- Partials        900      901       +1     

Impacted Files	Coverage Δ	Complexity Δ
...ozilla/fenix/library/bookmarks/BookmarkFragment.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...g/mozilla/fenix/library/history/HistoryFragment.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...illa/fenix/library/bookmarks/BookmarkController.kt	74.57% <87.50%> (+0.99%)	0.00 <0.00> (ø)
...mozilla/fenix/library/history/HistoryController.kt	80.00% <100.00%> (ø)	0.00 <0.00> (ø)
...mozilla/fenix/library/history/HistoryInteractor.kt	92.85% <100.00%> (ø)	13.00 <2.00> (ø)
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt	100.00% <0.00%> (ø)	6.00% <0.00%> (+1.00%)
...p/src/main/java/org/mozilla/fenix/home/HomeMenu.kt	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
.../org/mozilla/fenix/settings/DataChoicesFragment.kt	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
...lla/fenix/components/toolbar/DefaultToolbarMenu.kt	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d71df4d...69c5c9e. Read the comment docs.

[topotropic]

Thanks! I know @vesta0 answered to the original issue so it might be good for her to review it! I don't think we need to open the tab tray when people open a tab in the background but just show a snackbar – similar to what we do when people open links in the background when on a site.

[rocketsroger]

Thanks! I know @vesta0 answered to the original issue so it might be good for her to review it! I don't think we need to open the tab tray when people open a tab in the background but just show a snackbar – similar to what we do when people open links in the background when on a site.

@topotropic Thanks for reviewing. It's my mistake that I didn't check with you first. I was trying to behave the same as when we open multiple bookmark or history tabs. Current tabs tray is shown when opening multiple tabs, shouldn't we behave the same when just opening one bookmark or history tab in the background?

[topotropic]

@rocketsroger If people just open one bookmark via the menu, we can show the snackbar ("New tab opened" | "Switch", "New private tab opened" | "Switch") that we currently use when people open a link via context menu on a site. Let me know if you have any questions. Thank you!

[rocketsroger]

@rocketsroger If people just open one bookmark via the menu, we can show the snackbar ("New tab opened" | "Switch", "New private tab opened" | "Switch") that we currently use when people open a link via context menu on a site. Let me know if you have any questions. Thank you!

Sounds good. I'll update my implementation. Thanks!

[rocketsroger]

The snack bar implementation will be much bigger then originally estimated. As discussed offline, I've created an issue #19365 to track the follow up work. Thanks,

[jonalmeida]

LGTM ✅

[jonalmeida]

nice

[jonalmeida]

nit

Suggested change

	(activity as HomeActivity).browsingModeManager.mode = mode
	(activity as HomeActivity).components.useCases.tabsUseCases.let { tabsUseCases ->
	val homeActivity = activity as HomeActivity
	homeActivity.browsingModeManager.mode = mode
	homeActivity.components.useCases.tabsUseCases.let { tabsUseCases ->

[rocketsroger]

I'll update. Thanks!