Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #19273 - Added a line at the end of xml files #19295

Conversation

priyanka0906
Copy link
Contributor

fixes: #19273

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@priyanka0906 priyanka0906 requested review from a team as code owners April 28, 2021 17:09
@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@priyanka0906
Copy link
Contributor Author

@Amejia481 Please have a look.

Copy link
Member

@gabrielluong gabrielluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priyanka0906 This looks great. Thank you for this!

app/src/main/res/layout/mozac_browser_menu_item_switch.xml Outdated Show resolved Hide resolved
@gabrielluong gabrielluong self-assigned this Apr 28, 2021
@gabrielluong gabrielluong added pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify] labels Apr 28, 2021
@gabrielluong gabrielluong changed the title Added a line at the end of xml files For #19273 - Added a line at the end of xml files Apr 28, 2021
@gabrielluong gabrielluong reopened this Apr 29, 2021
@gabrielluong gabrielluong merged commit 05c38d9 into mozilla-mobile:master Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check all the xml files and add a line to the end of the files if it they don't have one.
3 participants