Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #18877 - Support updated PromptRequest AC APIs #19767

Merged
merged 2 commits into from Jun 3, 2021
Merged

For #18877 - Support updated PromptRequest AC APIs #19767

merged 2 commits into from Jun 3, 2021

Conversation

Mugurell
Copy link
Contributor

@Mugurell Mugurell commented Jun 2, 2021

This issue stemming from a race condition is fully resolved in AC by adding
support for having multiple prompts at a time.
Fenix needs just a small change to support the AC refactoring from mozilla-mobile/android-components#10273

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Mugurell Mugurell requested a review from Amejia481 June 2, 2021 12:05
@Mugurell Mugurell requested review from a team as code owners June 2, 2021 12:05
@Mugurell Mugurell added the pr:needs-ac-bump PR that needs a AC bump label Jun 2, 2021
This issue stemming from a race condition is fully resolved in AC by adding
support for having multiple prompts at a time.
Fenix needs just a small change to support the AC refactoring.
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2021

This pull request has conflicts when rebasing. Could you fix it @Mugurell? 🙏

@Amejia481
Copy link
Contributor

We are trying to figure out why these ui tests are failing locally and on CI

@Amejia481
Copy link
Contributor

It looks like the SaveLoginPrompt is getting auto dismiss when loading and the tests doesn't expect the prompt gets dismissed

@codecov-commenter
Copy link

Codecov Report

Merging #19767 (494e9f7) into master (eaf74a1) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19767      +/-   ##
============================================
- Coverage     35.40%   35.39%   -0.01%     
+ Complexity     1649     1648       -1     
============================================
  Files           545      545              
  Lines         22097    22097              
  Branches       3280     3281       +1     
============================================
- Hits           7823     7822       -1     
- Misses        13371    13372       +1     
  Partials        903      903              
Impacted Files Coverage Δ
...main/java/org/mozilla/fenix/share/ShareFragment.kt 0.00% <0.00%> (ø)
...rg/mozilla/fenix/settings/account/AccountUiView.kt 34.14% <0.00%> (-2.44%) ⬇️
...in/java/org/mozilla/fenix/perf/NavGraphProvider.kt 62.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf74a1...494e9f7. Read the comment docs.

@rvandermeulen rvandermeulen merged commit 0455cc3 into mozilla-mobile:master Jun 3, 2021
@Mugurell Mugurell deleted the 18877SupportNewAcApis branch June 4, 2021 05:13
grigoryk pushed a commit to grigoryk/fenix that referenced this pull request Jun 15, 2021
…illa-mobile#19767)

* For mozilla-mobile#18877 - Support updated PromptRequest AC APIs

This issue stemming from a race condition is fully resolved in AC by adding
support for having multiple prompts at a time.
Fenix needs just a small change to support the AC refactoring.

* Update Android Components version to 91.0.20210603145049

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Aug 11, 2021
…illa-mobile#19767)

* For mozilla-mobile#18877 - Support updated PromptRequest AC APIs

This issue stemming from a race condition is fully resolved in AC by adding
support for having multiple prompts at a time.
Fenix needs just a small change to support the AC refactoring.

* Update Android Components version to 91.0.20210603145049

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-ac-bump PR that needs a AC bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants