This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #18877 - Support updated PromptRequest AC APIs #19767
Merged
rvandermeulen
merged 2 commits into
mozilla-mobile:master
from
Mugurell:18877SupportNewAcApis
Jun 3, 2021
Merged
For #18877 - Support updated PromptRequest AC APIs #19767
rvandermeulen
merged 2 commits into
mozilla-mobile:master
from
Mugurell:18877SupportNewAcApis
Jun 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amejia481
approved these changes
Jun 2, 2021
This issue stemming from a race condition is fully resolved in AC by adding support for having multiple prompts at a time. Fenix needs just a small change to support the AC refactoring.
This pull request has conflicts when rebasing. Could you fix it @Mugurell? 🙏 |
We are trying to figure out why these ui tests are failing locally and on CI |
It looks like the |
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #19767 +/- ##
============================================
- Coverage 35.40% 35.39% -0.01%
+ Complexity 1649 1648 -1
============================================
Files 545 545
Lines 22097 22097
Branches 3280 3281 +1
============================================
- Hits 7823 7822 -1
- Misses 13371 13372 +1
Partials 903 903
Continue to review full report at Codecov.
|
grigoryk
pushed a commit
to grigoryk/fenix
that referenced
this pull request
Jun 15, 2021
…illa-mobile#19767) * For mozilla-mobile#18877 - Support updated PromptRequest AC APIs This issue stemming from a race condition is fully resolved in AC by adding support for having multiple prompts at a time. Fenix needs just a small change to support the AC refactoring. * Update Android Components version to 91.0.20210603145049 Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this pull request
Aug 11, 2021
…illa-mobile#19767) * For mozilla-mobile#18877 - Support updated PromptRequest AC APIs This issue stemming from a race condition is fully resolved in AC by adding support for having multiple prompts at a time. Fenix needs just a small change to support the AC refactoring. * Update Android Components version to 91.0.20210603145049 Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue stemming from a race condition is fully resolved in AC by adding
support for having multiple prompts at a time.
Fenix needs just a small change to support the AC refactoring from mozilla-mobile/android-components#10273
Pull Request checklist
To download an APK when reviewing a PR: