Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

cancel sync-strings on non-beta versions #19776

Merged
merged 2 commits into from
Jun 7, 2021
Merged

cancel sync-strings on non-beta versions #19776

merged 2 commits into from
Jun 7, 2021

Conversation

escapewindow
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@escapewindow escapewindow requested a review from st3fan June 2, 2021 19:53
@escapewindow escapewindow requested review from a team as code owners June 2, 2021 19:53
@codecov-commenter
Copy link

Codecov Report

Merging #19776 (26df1e8) into master (6dbe5ac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #19776   +/-   ##
=========================================
  Coverage     35.77%   35.77%           
  Complexity     1648     1648           
=========================================
  Files           545      545           
  Lines         21896    21896           
  Branches       3263     3263           
=========================================
  Hits           7833     7833           
  Misses        13160    13160           
  Partials        903      903           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbe5ac...26df1e8. Read the comment docs.

@escapewindow escapewindow added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Jun 7, 2021
@escapewindow escapewindow merged commit 9b6d7b6 into mozilla-mobile:master Jun 7, 2021
@escapewindow escapewindow removed the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Jun 7, 2021
grigoryk pushed a commit to grigoryk/fenix that referenced this pull request Jun 15, 2021
* cancel sync-strings on non-beta versions

* use fenix-beta-version 2.0.0
escapewindow added a commit that referenced this pull request Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants