This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #19820: Add labels for month and year spinners. #19870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19820
This follows the guidelines described in
developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/listbox_role
Note: As spinners do not have a label or a hint property, the only viable solution that follows UX design is to provide labels that are not visible (have 0 height and 0 width)
Pull Request checklist
No relevant unit tests for Talkback announcements.
No visual changes.
To download an APK when reviewing a PR: