Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No issue: Add full-junit-result in Flank config #19897

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

AaronMT
Copy link
Contributor

@AaronMT AaronMT commented Jun 8, 2021

JUnitReport.xml and FullJunitReport.xml are artifacts with differences. Full will include all tests results, including when tests failed and when passed on retry. This might expose more additional results for capturing as part of my Job/Push collection data on certain tasks. I think Junit report will contain one result per test. If a test fails, and then passes on retry, it will be recorded as a successful execution.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2021

Codecov Report

Merging #19897 (3d0dc90) into master (f06e3a6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #19897   +/-   ##
=========================================
  Coverage     36.84%   36.84%           
- Complexity     1628     1629    +1     
=========================================
  Files           536      536           
  Lines         20944    20944           
  Branches       3110     3110           
=========================================
  Hits           7716     7716           
+ Misses        12345    12344    -1     
- Partials        883      884    +1     
Impacted Files Coverage Δ
...in/java/org/mozilla/fenix/perf/NavGraphProvider.kt 62.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06e3a6...3d0dc90. Read the comment docs.

@AaronMT AaronMT closed this Jun 8, 2021
@AaronMT AaronMT deleted the test-full-junit-result-AaronMT branch June 8, 2021 19:24
@AaronMT AaronMT restored the test-full-junit-result-AaronMT branch June 8, 2021 20:18
@AaronMT AaronMT reopened this Jun 8, 2021
@AaronMT AaronMT changed the title Test full-junit-result in Flank config Add full-junit-result in Flank config Jun 8, 2021
@AaronMT AaronMT marked this pull request as ready for review June 8, 2021 20:18
@AaronMT AaronMT requested review from a team as code owners June 8, 2021 20:18
@AaronMT AaronMT self-assigned this Jun 8, 2021
@AaronMT AaronMT requested a review from isabelrios June 8, 2021 20:19
@AaronMT AaronMT changed the title Add full-junit-result in Flank config No issue: Add full-junit-result in Flank config Jun 8, 2021
Copy link
Contributor

@isabelrios isabelrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, let's try this to gather more data in case that helps, thanks!

@AaronMT AaronMT merged commit 3b6434d into master Jun 9, 2021
@bors bors bot deleted the test-full-junit-result-AaronMT branch June 9, 2021 14:55
grigoryk pushed a commit to grigoryk/fenix that referenced this pull request Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants