Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Address typos on start on home strings #19903

Merged

Conversation

Amejia481
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Amejia481 Amejia481 added the needs:review PRs that need to be reviewed label Jun 8, 2021
@Amejia481 Amejia481 requested a review from Delphine June 8, 2021 21:40
@Amejia481 Amejia481 requested review from a team as code owners June 8, 2021 21:40
@Amejia481 Amejia481 removed request for a team June 8, 2021 21:44
@gabrielluong gabrielluong added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Jun 8, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #19903 (0630a49) into master (f0bb70e) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19903      +/-   ##
============================================
+ Coverage     36.73%   36.76%   +0.02%     
- Complexity     1618     1619       +1     
============================================
  Files           534      534              
  Lines         20911    20911              
  Branches       3109     3109              
============================================
+ Hits           7682     7687       +5     
+ Misses        12349    12340       -9     
- Partials        880      884       +4     
Impacted Files Coverage Δ
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 3.42% <0.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0bb70e...0630a49. Read the comment docs.

@gabrielluong gabrielluong merged commit 268df19 into mozilla-mobile:master Jun 8, 2021
grigoryk pushed a commit to grigoryk/fenix that referenced this pull request Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants