Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #20017: a cold main session restore to measure_start_up #20020

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

mcomella
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@mcomella mcomella requested review from a team as code owners June 15, 2021 00:45
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #20020 (fa9d0a9) into master (dfc5628) will increase coverage by 4.08%.
The diff coverage is 31.58%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20020      +/-   ##
============================================
+ Coverage     32.83%   36.92%   +4.08%     
- Complexity     1382     1645     +263     
============================================
  Files           461      542      +81     
  Lines         19425    21055    +1630     
  Branches       2712     3154     +442     
============================================
+ Hits           6379     7774    +1395     
+ Misses        12510    12379     -131     
- Partials        536      902     +366     
Impacted Files Coverage Δ
...in/java/org/mozilla/fenix/AppRequestInterceptor.kt 93.02% <0.00%> (ø)
.../src/main/java/org/mozilla/fenix/SecureFragment.kt 0.00% <0.00%> (ø)
...g/mozilla/fenix/addons/AddonsManagementFragment.kt 6.62% <0.00%> (-0.19%) ⬇️
...illa/fenix/addons/InstalledAddonDetailsFragment.kt 0.00% <0.00%> (ø)
...fenix/android/DefaultActivityLifecycleCallbacks.kt 0.00% <0.00%> (ø)
.../mozilla/fenix/autofill/AutofillConfirmActivity.kt 0.00% <0.00%> (ø)
...g/mozilla/fenix/autofill/AutofillSearchActivity.kt 0.00% <0.00%> (ø)
...java/org/mozilla/fenix/autofill/AutofillService.kt 0.00% <0.00%> (ø)
...g/mozilla/fenix/autofill/AutofillUnlockActivity.kt 0.00% <0.00%> (ø)
...lla/fenix/browser/CustomTabContextMenuCandidate.kt 0.00% <0.00%> (ø)
... and 411 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba19960...fa9d0a9. Read the comment docs.

Copy link
Contributor

@MarcLeclair MarcLeclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, looks good to me. However , i wonder if the cold_main_restore need to mention we need to have a website open for the test case @mcomella (I approved since it works and everything is fine)

@mcomella
Copy link
Contributor Author

Works for me, looks good to me. However , i wonder if the cold_main_restore need to mention we need to have a website open for the test case @mcomella (I approved since it works and everything is fine)

@MarcLeclair I do mention this in stdout when you run it. Also, the PageStart == 2 assertion should trigger if you don't have a tab open (though the error message there isn't great if you don't read the stdout). Do you think this is sufficient?

@mcomella
Copy link
Contributor Author

Only changed .py so let's rerun.

@mcomella mcomella closed this Jun 17, 2021
@mcomella mcomella reopened this Jun 17, 2021
@mcomella mcomella merged commit 1b996e3 into mozilla-mobile:master Jun 17, 2021
@mcomella mcomella deleted the 20017-measure-restore branch June 17, 2021 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants