For FNXV2-17067: always show home in background behind search dialog #20573

eliserichards · 2021-07-29T20:36:27Z

For FNXV2-17067
POC for FNXV2-17191 spike

Navigate to home before we show the search dialog (so home shows as the background)
Make sure the homescreen can be interacted with behind search dialog
- Private mode button - ** should this open a new tab with the same URL in private mode??? Added comment here to get an answer
  - Breaking this out into a separate story: Handle switching between private and normal mode when we show home behind search #20654
- Top sites
- Jump back in - show all
- Recently saved - show all
- Collections
- Past explorations - show all
Handle back presses
- Navigate to wikipedia. Click on URL and see home. Press back button: home & search closes, be on wikipedia.
- Navigate to wikipedia. Click on URL and see home. Click on Pocket. Press back button: should navigate to wikipedia, not home.
  - Clicking on any link from the home screen opens a new tab
  - Check if we had a previous destination and then set parent (?)
  - Breaking this out into a separate story: Define backstack behavior when interacting with homescreen behind search #20655
Handle normal URL navigation
- Navigate to wikipedia. Click on URL and see home. Type in URL to go to google. Press back button: the back stack preserves wikipedia as the last destination (doesn't show homescreen)

Question: will this have any effect on the search widget?

Screenshots

20210803_145214.mp4

20210803_145249.mp4

Pull Request checklist

Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

click on Show All Checks,
click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
click on the "Fenix - assemble" task, then click "Run Artifacts".
the APK links should be on the left side of the screen, named for each CPU architecture

eliserichards · 2021-07-29T20:38:40Z

app/src/test/java/org/mozilla/fenix/components/toolbar/DefaultBrowserToolbarControllerTest.kt

-    }
-
-    @Test
-    fun handleToolbarClick_useNewSearchExperience() {


We switched over to the "new" search experience a while ago, so this test is a dupe of the one above

mergify · 2021-08-03T11:44:02Z

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

app/src/main/java/org/mozilla/fenix/home/recentbookmarks/view/RecentBookmarkItemViewHolder.kt

eliserichards · 2021-08-03T21:11:14Z

UI test: swipeToRemoveTabFromCollectionTest

csadilek

Looks good! We need a quick profiling session though and be careful not to introduce a performance regression. See comment on the original fix below.

app/src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt

mergify · 2021-08-04T21:08:33Z

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

eliserichards · 2021-08-05T18:27:50Z

Flaky UI tests:

swipeToRemoveTabFromCollectionTest
verifyTabTrayNotShowingStateHalfExpanded

Both ran fine locally ✅

eliserichards · 2021-08-05T21:00:39Z

app/src/main/res/layout/fragment_home.xml

@@ -68,7 +68,7 @@
        android:layout_height="match_parent"
        android:clipChildren="false"
        android:clipToPadding="false"
-        android:layout_marginBottom="48dp"
+        android:layout_marginBottom="88dp"


Allows collections to be seen on home behind the search dialog/toolbar

csadilek

Did some manual testing again, and took another profile.

Looks good to 🚢 and gather some feedback. I think the follow-up to hide the keyboard while scrolling could be moved in soon. It will make this work better as we add more things to the home screen.

...src/test/java/org/mozilla/fenix/home/recentbookmarks/DefaultRecentBookmarksControllerTest.kt

app/src/androidTest/java/org/mozilla/fenix/ui/CollectionTest.kt

app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt

eliserichards · 2021-08-09T15:09:47Z

@Mergifyio rebase

Update tests to show home behind search dialog. Remove unused test. Jump back in show all button is clickable behind search dialog Recently saved bookmarks show all button is clickable behind search dialog

Handle keyboard in controllers instead of viewholders. Update tests. Allow collections to be visible behind search dialog Dismiss keyboard and search dialog with navigateUp instead of just dismissing the keyboard Verify navigateUp in tests Adding ignore for flaky UI test Only resize home behind search dialog Add ignore for collection intermittent test Cleanup

mergify · 2021-08-09T15:10:37Z

Command rebase: success

Branch has been successfully rebased

…ozilla-mobile#20573) * Navigate to home on toolbar click. Handle back press from search dialog Update tests to show home behind search dialog. Remove unused test. Jump back in show all button is clickable behind search dialog Recently saved bookmarks show all button is clickable behind search dialog * Add feature flag * Past explorations show all button is clickable behind search dialog Handle keyboard in controllers instead of viewholders. Update tests. Allow collections to be visible behind search dialog Dismiss keyboard and search dialog with navigateUp instead of just dismissing the keyboard Verify navigateUp in tests Adding ignore for flaky UI test Only resize home behind search dialog Add ignore for collection intermittent test Cleanup

eliserichards requested review from a team as code owners July 29, 2021 20:36

eliserichards commented Jul 29, 2021

View reviewed changes

eliserichards added this to In Development (WIP limit - 15) in Android Engineering Team Kanban board via automation Jul 29, 2021

eliserichards force-pushed the FNXV2-17067-home-in-background branch 2 times, most recently from dfd20ab to 991fd61 Compare August 2, 2021 22:14

MozillaNoah reviewed Aug 3, 2021

View reviewed changes

app/src/main/java/org/mozilla/fenix/home/recentbookmarks/view/RecentBookmarkItemViewHolder.kt Outdated Show resolved Hide resolved

eliserichards force-pushed the FNXV2-17067-home-in-background branch 3 times, most recently from fd8dd3c to 591acec Compare August 3, 2021 19:44

eliserichards added the needs:review PRs that need to be reviewed label Aug 3, 2021

eliserichards moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Aug 3, 2021

This was referenced Aug 3, 2021

Handle switching between private and normal mode when we show home behind search #20654

Closed

Define backstack behavior when interacting with homescreen behind search #20655

Closed

csadilek reviewed Aug 4, 2021

View reviewed changes

app/src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt Outdated Show resolved Hide resolved

app/src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt Outdated Show resolved Hide resolved

eliserichards force-pushed the FNXV2-17067-home-in-background branch from 591acec to 8bec663 Compare August 4, 2021 21:11

eliserichards mentioned this pull request Aug 5, 2021

Show home behind search dialog without resizing #20696

Closed

eliserichards force-pushed the FNXV2-17067-home-in-background branch from 8bec663 to 3e13c78 Compare August 5, 2021 17:38

eliserichards closed this Aug 5, 2021

Android Engineering Team Kanban board automation moved this from Dev Complete (WIP limit - 5) to Done Aug 5, 2021

eliserichards reopened this Aug 5, 2021

Android Engineering Team Kanban board automation moved this from Done to In Development (WIP limit - 15) Aug 5, 2021

eliserichards mentioned this pull request Aug 5, 2021

Dismiss keyboard when scrolling home behind search dialog #20701

Closed

eliserichards added this to In progress in Home behind search via automation Aug 5, 2021

eliserichards force-pushed the FNXV2-17067-home-in-background branch from 3e13c78 to 41659b6 Compare August 5, 2021 20:04

eliserichards requested a review from csadilek August 5, 2021 20:55

eliserichards commented Aug 5, 2021

View reviewed changes

eliserichards force-pushed the FNXV2-17067-home-in-background branch from 41659b6 to 5b048d2 Compare August 5, 2021 21:04

eliserichards mentioned this pull request Aug 5, 2021

Intermittent UI test failures: collections and saved logins #20702

Closed

csadilek approved these changes Aug 6, 2021

View reviewed changes

Android Engineering Team Kanban board automation moved this from In Development (WIP limit - 15) to Reviewer approved, ready for test (WIP limit - ?) Aug 6, 2021

eliserichards force-pushed the FNXV2-17067-home-in-background branch from 5b048d2 to e63f03f Compare August 6, 2021 18:57

eliserichards added 3 commits August 9, 2021 15:10

Navigate to home on toolbar click. Handle back press from search dialog

8c649ce

Update tests to show home behind search dialog. Remove unused test. Jump back in show all button is clickable behind search dialog Recently saved bookmarks show all button is clickable behind search dialog

Add feature flag

bd15bca

eliserichards force-pushed the FNXV2-17067-home-in-background branch from e63f03f to 8c00ebf Compare August 9, 2021 15:10

eliserichards added pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Aug 9, 2021

mergify bot merged commit 7fdad97 into mozilla-mobile:main Aug 9, 2021

Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done Aug 9, 2021

Home behind search automation moved this from In progress to Done Aug 9, 2021

eliserichards moved this from Done to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Aug 9, 2021

eliserichards added the eng:qa:needed QA Needed label Aug 9, 2021

eliserichards linked an issue Aug 9, 2021 that may be closed by this pull request

Show home in background behind search #20760

Closed

9 tasks

eliserichards removed the eng:qa:needed QA Needed label Aug 9, 2021

eliserichards removed this from Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Aug 9, 2021

eliserichards removed this from Done in Home behind search Aug 9, 2021

Mugurell mentioned this pull request Aug 10, 2021

Homescreen shows an empty space above the toolbar #20770

Closed

sunilk9211235 mentioned this pull request Aug 16, 2021

For #20833: Removed extra margin at homescreen bottom #20860

Closed

3 tasks

bigConifer mentioned this pull request Dec 31, 2021

Bookmarklets with native Javascript dialogs stopped working #23023

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For FNXV2-17067: always show home in background behind search dialog #20573

For FNXV2-17067: always show home in background behind search dialog #20573

eliserichards commented Jul 29, 2021 •

edited

eliserichards Jul 29, 2021 •

edited

mergify bot commented Aug 3, 2021

eliserichards commented Aug 3, 2021

csadilek left a comment

mergify bot commented Aug 4, 2021

eliserichards commented Aug 5, 2021

eliserichards Aug 5, 2021

csadilek left a comment

eliserichards commented Aug 9, 2021

mergify bot commented Aug 9, 2021

For FNXV2-17067: always show home in background behind search dialog #20573

For FNXV2-17067: always show home in background behind search dialog #20573

Conversation

eliserichards commented Jul 29, 2021 • edited

Screenshots

Pull Request checklist

To download an APK when reviewing a PR:

eliserichards Jul 29, 2021 • edited

Choose a reason for hiding this comment

mergify bot commented Aug 3, 2021

eliserichards commented Aug 3, 2021

csadilek left a comment

Choose a reason for hiding this comment

mergify bot commented Aug 4, 2021

eliserichards commented Aug 5, 2021

eliserichards Aug 5, 2021

Choose a reason for hiding this comment

csadilek left a comment

Choose a reason for hiding this comment

eliserichards commented Aug 9, 2021

mergify bot commented Aug 9, 2021

eliserichards commented Jul 29, 2021 •

edited

eliserichards Jul 29, 2021 •

edited