-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Issue #21642: Remove in-progress media tab from homescreen #21670
Conversation
@@ -24,16 +24,9 @@ import kotlin.math.max | |||
fun BrowserState.asRecentTabs(): List<RecentTab> { | |||
return mutableListOf<RecentTab>().apply { | |||
val lastOpenedNormalTab = lastOpenedNormalTab | |||
val inProgressMediaTab = inProgressMediaTab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also wrap this behind a feature flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wasn't sure to what extent we should be "removing it". So I opted for this solution so we can land it before the beta cut.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another reason I forgot about, is that we get intermittent test failures when we have feature flags here. See #21557.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's land as is. Thought about this last week and it's a trade-off. We don't want feature flags to be too fine-grained, so arguably this is a change in behaviour of an existing feature, as opposed to a feature itself. We can revert this to enable again when we want it (have time to add media controls).
8d837ea
to
92b734b
Compare
@@ -24,16 +24,9 @@ import kotlin.math.max | |||
fun BrowserState.asRecentTabs(): List<RecentTab> { | |||
return mutableListOf<RecentTab>().apply { | |||
val lastOpenedNormalTab = lastOpenedNormalTab | |||
val inProgressMediaTab = inProgressMediaTab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's land as is. Thought about this last week and it's a trade-off. We don't want feature flags to be too fine-grained, so arguably this is a change in behaviour of an existing feature, as opposed to a feature itself. We can revert this to enable again when we want it (have time to add media controls).
Not removing the other logic because we're going to re-add this after some refinement in the future.
To download an APK when reviewing a PR: