Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #22175: Telemetry for deleting a search term group from recent searches on home #22176

Merged

Conversation

eliserichards
Copy link
Contributor

For #22175

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@eliserichards eliserichards added the needs:review PRs that need to be reviewed label Oct 26, 2021
@eliserichards eliserichards requested review from a team as code owners October 26, 2021 21:56
@eliserichards eliserichards linked an issue Nov 1, 2021 that may be closed by this pull request
@eliserichards eliserichards changed the title For #22175: Telemetry event for deleting a search term group from the recent searches section on home For #22175: Telemetry for deleting a search term group from recent searches on home Nov 1, 2021
@eliserichards
Copy link
Contributor Author

eliserichards commented Nov 1, 2021

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?

    • This data will help us understand our new home screen features, and what data users want to see/don’t want to see.

  2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

    • This is for the product MR2 requirements.

  3. What alternative methods did you consider to answer these questions? Why were they not sufficient?

    • There are no other alternatives.

  4. Can current instrumentation answer these questions?

    • Yes: this change will mitigate the risk of these important metrics expiring.

  5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

    Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
recent_searches.group_deleted: A user has deleted a search term group from the "Recent searches" section on the homescreen using the long-press menu "Remove" option. This removes the item from the homescreen, but does not delete the item from history. Category 2 - interaction data #22175
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.

  2. How long will this data be collected? Choose one of the following:

    • These metrics expire in 6 months (April 2022).
  3. What populations will you measure?

    • All channels, all locales, all countries

  4. If this data collection is default on, what is the opt-out mechanism for users?

    • Default Glean SDK opt-out mechanism.

  5. Please provide a general description of how you will analyze this data.

    • Glean and Amplitude.

  6. Where do you intend to share the results of your analysis?

    • Only on Glean, Amplitude, and with mobile teams (no change).

  7. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?

    • No third-party tools.

@eliserichards eliserichards added needs:data-review PR is awaiting a data review pr:approved PR that has been approved and removed needs:review PRs that need to be reviewed labels Nov 1, 2021
@eliserichards
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2021

rebase

✅ Branch has been successfully rebased

@eliserichards eliserichards force-pushed the 22175-delete-group-home-telemetry branch from a7f2a2f to e093301 Compare November 1, 2021 16:22
@rocketsroger
Copy link
Contributor

rocketsroger commented Nov 1, 2021

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?
   
   * This data will help us understand our new home screen features, and what data users want to see/don’t want to see.

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
   
   * This is for the product MR2 requirements.

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?
   
   * There are no other alternatives.

4. Can current instrumentation answer these questions?
   
   * Yes: this change will mitigate the risk of these important metrics expiring.

5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
   
   Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
recent_searches.group_deleted: A user has deleted a search term group from the "Recent searches" section on the homescreen using the long-press menu "Remove" option. This removes the item from the homescreen, but does not delete the item from history. Category 2 - interaction data #22175

1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
   
   * https://dictionary.telemetry.mozilla.org/apps/fenix

2. How long will this data be collected? Choose one of the following:
   
* These metrics expire in 6 months (April 2022).

3. What populations will you measure?
   
   * All channels, all locales, all countries

4. If this data collection is default on, what is the opt-out mechanism for users?
   
   * Default Glean SDK opt-out mechanism.

5. Please provide a general description of how you will analyze this data.
   
   * Glean and Amplitude.

6. Where do you intend to share the results of your analysis?
   
   * Only on Glean, Amplitude, and with mobile teams (no change).

7. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
   
   * No third-party tools.

Data Review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the "Send Usage Data" preference in the application settings

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, collection set to end or be renewed by 2022-04-01

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

  1. Is the data collection request for default-on or default-off?

default-on

  1. Does the instrumentation include the addition of any new identifiers?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does the data collection use a third-party collection tool?

No

Result

data-review+

@rocketsroger rocketsroger removed the needs:data-review PR is awaiting a data review label Nov 1, 2021
@eliserichards
Copy link
Contributor Author

@Mergifyio rebase

…group from the recent searches section on home
@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2021

rebase

✅ Branch has been successfully rebased

@eliserichards eliserichards force-pushed the 22175-delete-group-home-telemetry branch from e093301 to 617e568 Compare November 1, 2021 19:32
@eliserichards eliserichards added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Nov 1, 2021
@mergify mergify bot merged commit e4cc22f into mozilla-mobile:main Nov 1, 2021
@rocketsroger
Copy link
Contributor

@Mergifyio backport releases_v94.0.0

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2021

backport releases_v94.0.0

✅ Backports have been created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MR2 telemetry: delete group from Recent Searches
3 participants