Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #22271 Improve URL accessing from the clipboard for Android 12 and above. #22391

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Nov 9, 2021

As accessing the clipboard is sensitive action, on Android 12 and above we changed the UI to not show (access the clipboard) the URL unless the user request to do so.

Behavior on Android 12 and above

We show the "Fill link from clipboard" item (but not the URL item) when the user clicks it, we fill the toolbar with its content.

Demo

Behavior pre Android 12 and above

Same as before show the "Fill link from clipboard" item and the URL item, when the user clicks it, we navigate to the site.

clipboard_pre_android_12

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Amejia481 Amejia481 force-pushed the for-22271 branch 2 times, most recently from 3eaa0c9 to 2f086b7 Compare November 10, 2021 16:17
@Amejia481 Amejia481 marked this pull request as ready for review November 10, 2021 16:17
@Amejia481 Amejia481 requested review from a team as code owners November 10, 2021 16:17
@Amejia481 Amejia481 added the needs:review PRs that need to be reviewed label Nov 10, 2021
@Amejia481 Amejia481 requested review from csadilek and removed request for a team November 10, 2021 16:46
Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think this is a good immediate solution without losing any functionality, and we can improve later. I noticed two things though

  • After filling in from clipboard the cursor is at the beginning instead of at the end. After pasting text the user expectation is for the cursor to be at the end of the text.
  • The keyboard pops up and down when filling in.

Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Amejia481
Copy link
Contributor Author

We will wait until early next week to land, after the long weekend pass.

@topotropic
Copy link

Looks good to me, nice fix!

@Amejia481 Amejia481 added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Nov 15, 2021
@mergify mergify bot merged commit 94a543a into mozilla-mobile:main Nov 15, 2021
@Amejia481
Copy link
Contributor Author

@Mergifyio backport releases_v95.0.0

@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2021

backport releases_v95.0.0

✅ Backports have been created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants