This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #22271 Improve URL accessing from the clipboard for Android 12 and above. #22391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amejia481
force-pushed
the
for-22271
branch
2 times, most recently
from
November 10, 2021 16:17
3eaa0c9
to
2f086b7
Compare
csadilek
reviewed
Nov 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I think this is a good immediate solution without losing any functionality, and we can improve later. I noticed two things though
- After filling in from clipboard the cursor is at the beginning instead of at the end. After pasting text the user expectation is for the cursor to be at the end of the text.
- The keyboard pops up and down when filling in.
Amejia481
commented
Nov 10, 2021
csadilek
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We will wait until early next week to land, after the long weekend pass. |
Looks good to me, nice fix! |
… Android 12 and above.
Amejia481
added
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
and removed
needs:review
PRs that need to be reviewed
labels
Nov 15, 2021
@Mergifyio backport releases_v95.0.0 |
✅ Backports have been created
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As accessing the clipboard is sensitive action, on Android 12 and above we changed the UI to not show (access the clipboard) the URL unless the user request to do so.
Behavior on Android 12 and above
We show the "Fill link from clipboard" item (but not the URL item) when the user clicks it, we fill the toolbar with its content.
Behavior pre Android 12 and above
Same as before show the "Fill link from clipboard" item and the URL item, when the user clicks it, we navigate to the site.
Pull Request checklist
To download an APK when reviewing a PR: