Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #1710: Create scaffolding for Robolectric tests #2282

Merged
merged 1 commit into from
May 7, 2019

Conversation

colintheshots
Copy link
Contributor

I added a basic Robolectric integration. This required downgrading to JUnit 4. I had to mock out parts of the application like background sync, but couldn't do a proper test of the bookmarks fragment yet because the Android Component had its CoroutineScope set as internal visibility only.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@colintheshots colintheshots requested a review from a team as a code owner May 5, 2019 01:17
@boek
Copy link
Contributor

boek commented May 6, 2019

Looks like a handful of builds are failing at:

e: /opt/fenix/app/src/test/java/org/mozilla/fenix/library/bookmarks/BookmarkFragmentTest.kt: (7, 30): Unresolved reference: testing
e: /opt/fenix/app/src/test/java/org/mozilla/fenix/library/bookmarks/BookmarkFragmentTest.kt: (8, 30): Unresolved reference: testing
e: /opt/fenix/app/src/test/java/org/mozilla/fenix/library/bookmarks/BookmarkFragmentTest.kt: (32, 36): Unresolved reference: FragmentScenario
e: /opt/fenix/app/src/test/java/org/mozilla/fenix/library/bookmarks/BookmarkFragmentTest.kt: (43, 13): Unresolved reference: launchFragmentInContainer
e: /opt/fenix/app/src/test/java/org/mozilla/fenix/library/bookmarks/BookmarkFragmentTest.kt: (56, 31): Cannot infer a type for this parameter. Please specify it explicitly.

@colintheshots colintheshots merged commit 96b6894 into mozilla-mobile:master May 7, 2019
@colintheshots colintheshots deleted the fix1710 branch May 7, 2019 21:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants