For #1994: Re-architect state handling code #2382

colintheshots · 2019-05-09T17:26:08Z

Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
Tests: This PR includes thorough tests or an explanation of why it does not
Changelog: This PR includes a changelog entry or does not need one
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

colintheshots · 2019-05-09T18:36:16Z

I'll fix the unit tests.

colintheshots requested a review from a team as a code owner May 9, 2019 17:26

colintheshots force-pushed the fix1994 branch from 93ca6ff to fe4a81b Compare May 9, 2019 17:27

colintheshots force-pushed the fix1994 branch from fe4a81b to b4fd951 Compare May 9, 2019 19:18

For mozilla-mobile#1994: Re-architect state handling code

ad5c967

colintheshots force-pushed the fix1994 branch from b4fd951 to ad5c967 Compare May 9, 2019 19:21

colintheshots changed the title ~~Re-architect state handling code~~ For #1994: Re-architect state handling code May 9, 2019

boek approved these changes May 9, 2019

View reviewed changes

Merge branch 'master' into fix1994

c8593d1

boek merged commit ccbc14a into mozilla-mobile:master May 9, 2019

colintheshots deleted the fix1994 branch May 10, 2019 00:31

cadeyrn mentioned this pull request May 10, 2019

[Bug] private mode shows tabs from normal mode #2411

Closed

Provide feedback