Upgrade AndroidX Espresso Deps and support API 30 #23904
Conversation
AaronMT
force-pushed
the
androidx-dep-UI-test-upgrade
branch
3 times, most recently
from
93a5d9b
to
e4ef7e9
Compare
AaronMT
force-pushed
the
androidx-dep-UI-test-upgrade
branch
16 times, most recently
from
930457f
to
1d5fe0b
Compare
AaronMT
force-pushed
the
androidx-dep-UI-test-upgrade
branch
from
1d5fe0b
to
08d2a12
Compare
AaronMT
force-pushed
the
androidx-dep-UI-test-upgrade
branch
3 times, most recently
from
e3d137c
to
3779745
Compare
AaronMT
force-pushed
the
androidx-dep-UI-test-upgrade
branch
7 times, most recently
from
5c8bf13
to
d13c496
Compare
AaronMT
force-pushed
the
androidx-dep-UI-test-upgrade
branch
6 times, most recently
from
8cd8333
to
e964d3b
Compare
app/src/androidTest/java/org/mozilla/fenix/ui/robots/NotificationRobot.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/SitePermissionsTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/SitePermissionsTest.kt
Outdated
Show resolved
Hide resolved
| // allow app to record video | ||
| clickAppPermissionButton(false) | ||
| // allow app to record audio | ||
| clickAppPermissionButton(false) |
There was a problem hiding this comment.
can we keep this test for full coverage by using the clickDenyAppPermissionButton() method? I see there's a rule to grant camera and mic permissions by default, so maybe this is feasible only in a separate test class?
There was a problem hiding this comment.
Note: Re-visit after landing as is
There was a problem hiding this comment.
Tracking in: #23298
| navigationToolbar { | ||
| }.enterURLAndEnterToBrowser(testPage.toUri()) { | ||
| }.clickStartMicrophoneButton { | ||
| clickAppPermissionButton(false) |
There was a problem hiding this comment.
same as above, can we keep this?
There was a problem hiding this comment.
Note: Re-visit after landing as is
There was a problem hiding this comment.
Tracking in: #23298
| } | ||
|
|
||
| fun clickDenyAppPermissionButton() { | ||
| TestHelper.denyPermission() |
There was a problem hiding this comment.
See my comments about using this method to keep two tests. Otherwise, this is not used anywhere and in that case, could be deleted?
There was a problem hiding this comment.
Note: Re-visit after landing as is
There was a problem hiding this comment.
Tracking in: #23298
AaronMT
force-pushed
the
androidx-dep-UI-test-upgrade
branch
5 times, most recently
from
9440094
to
a6db976
Compare
AaronMT
force-pushed
the
androidx-dep-UI-test-upgrade
branch
from
a6db976
to
27e4d2b
Compare
For #23676. Opening as draft to shake out test issues and fix them as they come.