Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Teases apart ViewModel dependencies #2499

Merged
merged 3 commits into from
May 15, 2019
Merged

Teases apart ViewModel dependencies #2499

merged 3 commits into from
May 15, 2019

Conversation

boek
Copy link
Contributor

@boek boek commented May 15, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@boek boek requested a review from a team as a code owner May 15, 2019 05:49
ekager
ekager approved these changes May 15, 2019
View reviewed changes
app/src/main/java/org/mozilla/fenix/FenixViewModelProvider.kt
@@ -0,0 +1,31 @@
package org.mozilla.fenix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - license

@ekager
Copy link
Contributor

ekager commented May 15, 2019

So should we close #2492? I'm assuming this is replacing that one?

@boek
Copy link
Contributor Author

boek commented May 15, 2019

@ekager yep!

@boek boek merged commit c5e5ef4 into mozilla-mobile:master May 15, 2019
@boek boek deleted the fixRxViewModels branch May 15, 2019 06:16
This was referenced May 15, 2019
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ekager ekager ekager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boek @ekager