This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #24855: Allow updating and deleting an existing address. #25031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcarare
added
the
pr:work-in-progress
mcarare
force-pushed
the
24855
branch
12 times, most recently
from
1c1427a
to
dcb91dd
Compare
gabrielluong
reviewed
May 2, 2022
app/src/main/java/org/mozilla/fenix/settings/address/view/AddressEditorView.kt
Outdated
Show resolved
Hide resolved
mcarare
force-pushed
the
24855
branch
7 times, most recently
from
3ada316
to
98c161b
Compare
mcarare
changed the title
mcarare
force-pushed
the
24855
branch
7 times, most recently
from
9369651
to
99d7aa2
Compare
mcarare
force-pushed
the
24855
branch
5 times, most recently
from
66bc668
to
dbf5351
Compare
I rearranged the code between commits and I moved the strings in the respective commits (Although we have previously pre-landed strings for some features). I have preferred to have all commits in a single PR because all the work was related and it was based on previous changes. The alternative would have been to start them individually and be blocked by waiting for a review or not wait for a review before starting related work and be forced to constantly rebase work after reviews. |
gabrielluong
approved these changes
May 6, 2022
| val addressEditorView = spyk(AddressEditorView(binding, interactor, address)) | ||
| addressEditorView.bind() | ||
|
|
||
| assertEquals(View.VISIBLE, binding.deleteButton.visibility) |
There was a problem hiding this comment.
Just a note that we could've tested the isVisible property instead.
|
|
||
| controller.handleUpdateAddress(address.guid, addressFields) | ||
|
|
||
| coVerifySequence { |
There was a problem hiding this comment.
This is interesting - first time seeing this usage.
mcarare
force-pushed
the
24855
branch
3 times, most recently
from
10e64c1
to
36d6d4d
Compare
mcarare
added
the
pr:needs-landing
|
Removing the needs-landing label since it is blocking the AC bump. |
gabrielluong
removed
the
pr:needs-landing
…ast address is deleted.
mcarare
added
the
pr:needs-landing
This was referenced May 10, 2022
This was
linked to
issues
May 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24855
Pull Request checklist
To download an APK when reviewing a PR: