Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #26185: add telemetry events for synced history screen #26251

Closed

Conversation

mavduevskiy
Copy link
Contributor

@mavduevskiy mavduevskiy commented Jul 30, 2022

Closes #26185

draft

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #26185

@mavduevskiy
Copy link
Contributor Author

@rocketsroger
May be instead of creating new events for synced history fragment, we could pass extras to the existing history events to distinguish the source?

removed_all:
type: event
description: |
A user removed all history items
Copy link
Contributor

@rocketsroger rocketsroger Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removing all history items? or just Synced history items? This question applies to all of the events under synced history as well.

bugs:
- https://github.com/mozilla-mobile/fenix/issues/26185
data_reviews:
- https://github.com/mozilla-mobile/fenix/issues/26185
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should point to this PR, not the issue. Thanks

@rocketsroger
Copy link
Contributor

@rocketsroger May be instead of creating new events for synced history fragment, we could pass extras to the existing history events to distinguish the source?

As discussed, let's clarify the requirements for the delete and search buttons when showing synced history. If the requirement is not to show those buttons, then we can just create the events without using extras. I lean towards not using extras to multiplex the history telemetry events because: 1. This will effect history telemetry queries. 2. If we separate the implementation of history fragment vs synced history fragment in the future then sharing telemetry events won't be as useful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Telemetry to Synced History Screen
2 participants