Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

mergify: allow complete-push check as an alternative to complete-pr i… #26902

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

jcristau
Copy link
Contributor

@jcristau jcristau commented Sep 9, 2022

…n queue conditions

PRs created by github actions don't get a pull-request taskcluster graph scheduled (because that is only done for PRs created by collaborators). However, if the PR is created in the main fenix repo, typically because it comes from one of our internal github workflows, then we get a push graph, which is sufficient to run the required checks.

This change lets mergify consider a green complete-push task as sufficient to queue a PR (in addition to all the other conditions, e.g. wrt review), which will allow PRs created by the
update-nimbus-experiments workflow to be queued by mergify instead of having to be merged by a repo admin.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much for the context of this change 👍

…n queue conditions

PRs created by github actions don't get a pull-request taskcluster graph
scheduled (because that is only done for PRs created by collaborators).
However, if the PR is created in the main fenix repo, typically because
it comes from one of our internal github workflows, then we get a push
graph, which is sufficient to run the required checks.

This change lets mergify consider a green `complete-push` task as
sufficient to queue a PR (in addition to all the other conditions, e.g.
wrt review), which will allow PRs created by the
update-nimbus-experiments workflow to be queued by mergify instead of
having to be merged by a repo admin.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants