This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #2780 - Fix home screen attributes for API 21-22 #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekager
commented
May 24, 2019
| android:textStyle="bold" | ||
| android:visibility="gone" /> | ||
|
|
||
| <Button | ||
| android:id="@+id/sign_out_button" |
There was a problem hiding this comment.
@boek are these three buttons supposed to look the same? The last one didn't have a background so I added it.
There was a problem hiding this comment.
No, the sign out button has no background
There was a problem hiding this comment.
We're not shipping this right now, so I'm going to go ahead and land this now
boek
approved these changes
May 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist