This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Closes EXP-3078 Use Nimbus.fetchExperiments() more intentionally #28760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
added
the
pr:work-in-progress
jhugman
force-pushed
the
jhugman/exp-3078-tighten-up-background-networking
branch
2 times, most recently
from
cb4653e
to
5666fc6
Compare
jhugman
changed the title
jhugman
force-pushed
the
jhugman/exp-3078-tighten-up-background-networking
branch
from
5666fc6
to
8dee6ba
Compare
jhugman
force-pushed
the
jhugman/exp-3078-tighten-up-background-networking
branch
from
8dee6ba
to
fb64656
Compare
t-p-white
reviewed
Feb 6, 2023
| } | ||
|
|
||
| @Test | ||
| fun `GIVEN a nimbus object WHEN calling maybeFetchExperiments before an interval THEN do not call fetchExperiments`() { |
There was a problem hiding this comment.
should we also have a test for 'at' interval?
t-p-white
approved these changes
Feb 6, 2023
jhugman
force-pushed
the
jhugman/exp-3078-tighten-up-background-networking
branch
from
fb64656
to
ed7b659
Compare
jhugman
added
pr:needs-landing-squashed
bors
bot
deleted the
jhugman/exp-3078-tighten-up-background-networking
branch
|
We are getting really close to release v111, is it OK to ship this feature? |
JohanLorenzo
pushed a commit
to mozilla-mobile/firefox-android
that referenced
this pull request
Feb 13, 2023
…lly (mozilla-mobile/fenix#28760) * Add maybeFetchExperiments * Move fetchExperiments from onCreate to after visual completeness * Address reviewer comments / ktlint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EXP-3078.
Pull Request checklist
QA
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-debugtask.View task in Taskclusterin the newDETAILSsection.GitHub Automation
Used by GitHub Actions.