Bug 1553096 - Do not put Treeherder route when on untrusted repo

[JohanLorenzo]

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1553096#c6

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry or does not need one
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

[JohanLorenzo]

Please do not land before https://bugzilla.mozilla.org/show_bug.cgi?id=1553096#c8 is responded

[sblatz]

@JohanLorenzo Is this safe to land or should we close it?

[JohanLorenzo]

Thanks for digging this PR up @sblatz, it had slipped my mind! r? @mitchhentges

[mitchhentges]

I think that this is indented too far

[JohanLorenzo]

I'm sorry, I'm not sure to follow this sentence. Would you mind expanding on it?

[mitchhentges]

Sure - I think there's a formatting issue, where this line is 2 spaces too far.
Right now, it looks like:

          routes:
            $flatten:
              - statuses  # Automatically added by taskcluster-github. It must be explicit because of Chain of Trust
              - $if: 'trust_level == 3'
                then:
                    - tc-treeherder.v2.fenix.${head_rev}
else: []

and it should look like

          routes:
            $flatten:
              - statuses  # Automatically added by taskcluster-github. It must be explicit because of Chain of Trust
              - $if: 'trust_level == 3'
                then:
                  - tc-treeherder.v2.fenix.${head_rev}
else: []

[JohanLorenzo]

facepalms My apologies, I kept reading "intended too far", instead of "indented too far". Thanks for catching it, and for the thorough explanations. Fixed