This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Migrates "raptor" build type to work for chrome-perf-testing, too #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchhentges
force-pushed
the
2523-perf-test-build-type
branch
3 times, most recently
from
7beb18c
to
cc15b1f
Compare
hawkinsw
reviewed
May 28, 2019
There was a problem hiding this comment.
Although I don't generally know the specifics for these configuration files (etc), I did look over this and it does pass the sniff test. I am really excited for this to land!
Thanks for the hard work, @mitchhentges
mitchhentges
force-pushed
the
2523-perf-test-build-type
branch
2 times, most recently
from
02d8592
to
7fff6ec
Compare
mitchhentges
force-pushed
the
2523-perf-test-build-type
branch
from
7fff6ec
to
813bd68
Compare
JohanLorenzo
approved these changes
Jun 3, 2019
| @@ -77,7 +77,7 @@ def secret_index(name): | |||
|
|
|||
| capitalized_track = upper_case_first_letter(track) | |||
| gradle_commands = ( | |||
| './gradlew --no-daemon -PcrashReports=true -Ptelemetry=true -PversionName={} clean test assemble{}'.format( | |||
| './gradlew --no-daemon -PversionName={} clean test assemble{}'.format( | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2523.
Migrates
index.project.mobile.fenix.v2.raptor.latest.{abi}to
index.project.mobile.fenix.v2.performance-test.latest.{abi}Performance test builds are now debuggable, and have telemetry enabled.
Pull Request checklist