This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Closes #270: Integrate browser-storage-sync #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… storage and toolbar autocompletion
ghost
assigned 
colintheshots
approved these changes
Jan 29, 2019
grigoryk
pushed a commit
to grigoryk/fenix
that referenced
this pull request
Jan 30, 2019
…ted architectures This fixes a regression from mozilla-mobile#294 That patch adds a dependency which loads some native libraries. Those native libs are shipped for a variety of architectures. Specifically, there are versions of aarch64 and armv7. What seems to happen is that since those libraries are loaded first (GV is lazily initialized after history stuff), and since aarch64 versions of these libs is chosen by the native loader, consequent native loads select for the same abi type. aarch64 version of libmozglue isn't there, loader fails to find it and we crash. Being explicit with the abiFilter in the product flavour definitions strips out aarch64 app-services libs from the apk. When they're loaded first, armv7 versions are picked (since we don't have any other ones), and everything works correctly afterwards. Another way to achieve the same result would be to exclude arm64 libs via packagignOptions directive: packagingOptions { exclude "lib/arm64-v8a/**" } ... but that's a less flexible approach in the longer term.
boek
pushed a commit
that referenced
this pull request
Jan 30, 2019
…ted architectures This fixes a regression from #294 That patch adds a dependency which loads some native libraries. Those native libs are shipped for a variety of architectures. Specifically, there are versions of aarch64 and armv7. What seems to happen is that since those libraries are loaded first (GV is lazily initialized after history stuff), and since aarch64 versions of these libs is chosen by the native loader, consequent native loads select for the same abi type. aarch64 version of libmozglue isn't there, loader fails to find it and we crash. Being explicit with the abiFilter in the product flavour definitions strips out aarch64 app-services libs from the apk. When they're loaded first, armv7 versions are picked (since we don't have any other ones), and everything works correctly afterwards. Another way to achieve the same result would be to exclude arm64 libs via packagignOptions directive: packagingOptions { exclude "lib/arm64-v8a/**" } ... but that's a less flexible approach in the longer term.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for persisting history and providing toolbar url autocomplete suggestions via
browser-storage-synccomponent.Underneath, this is powered by a Rust version of places.
You can poke at the sqlite database this creates over at
/data/data/org.mozilla.fenix.debug/files/places.sqlite.Once we integrate FxA, feature-sync and upcoming SyncManager components, this component will also power history sync.